fix(issue-selector): align provider logo#2738
Open
janburzinski wants to merge 1 commit into
Open
Conversation
Contributor
Greptile SummaryThis PR fixes the alignment of provider logos in the issue selector header by changing the icon's Tailwind size class from
Confidence Score: 5/5Safe to merge — this is a one-line visual fix with no logic changes and no risk of regression. The change is a single Tailwind utility class swap on an icon inside a fixed-size container. It has no effect on component logic, data flow, or behaviour — only the rendered size of the SVG icon changes, matching the intended visual design shown in the PR screenshots. No files require special attention.
|
| Filename | Overview |
|---|---|
| apps/emdash-desktop/src/renderer/features/tasks/components/issue-selector/issue-selector.tsx | Single Tailwind class change: size-[90%] → size-full on the Icon inside ProviderLogo; no logic changes, no risk. |
Flowchart
%%{init: {'theme': 'neutral'}}%%
flowchart TD
A["ProviderLogo component"] --> B["outer span\nh-3.5 w-3.5 container"]
B --> C["Icon\nsize-full (was: size-[90%])"]
C --> D["SVG fills container 100%\n(was 90%, left visual gap)"]
%%{init: {'theme': 'base', 'themeVariables': {"darkMode": true, "background": "#0d1117", "primaryColor": "#21262d", "primaryTextColor": "#e6edf3", "primaryBorderColor": "#8b949e", "lineColor": "#8b949e", "textColor": "#e6edf3", "edgeLabelBackground": "#161b22", "actorBkg": "#21262d", "actorBorder": "#8b949e", "actorTextColor": "#e6edf3", "actorLineColor": "#8b949e", "signalColor": "#8b949e", "signalTextColor": "#e6edf3", "noteBkgColor": "#373320", "noteBorderColor": "#d4a72c", "noteTextColor": "#f0e6c0", "labelBoxBkgColor": "#21262d", "labelBoxBorderColor": "#8b949e", "labelTextColor": "#e6edf3", "loopTextColor": "#e6edf3", "activationBkgColor": "#30363d", "activationBorderColor": "#8b949e"}}}%%
flowchart TD
A["ProviderLogo component"] --> B["outer span\nh-3.5 w-3.5 container"]
B --> C["Icon\nsize-full (was: size-[90%])"]
C --> D["SVG fills container 100%\n(was 90%, left visual gap)"]
Reviews (1): Last reviewed commit: "fix(issue-selector): align provider logo" | Re-trigger Greptile
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Screenshot/Recording (if applicable)
just before:

before vs after:

Checklist
messages and, when possible, the PR title