Skip to content

fix(issue-selector): align provider logo#2738

Open
janburzinski wants to merge 1 commit into
mainfrom
jan/eng-1705-misalignment-of-logo-and-ticket-id-in-header-esp-for-linear
Open

fix(issue-selector): align provider logo#2738
janburzinski wants to merge 1 commit into
mainfrom
jan/eng-1705-misalignment-of-logo-and-ticket-id-in-header-esp-for-linear

Conversation

@janburzinski

Copy link
Copy Markdown
Collaborator

Description

  • make provider logos fill their container in the issue selector header

Screenshot/Recording (if applicable)

just before:
image

before vs after:
image

Checklist
  • I kept this PR small and focused
  • I ran a self-review before opening this PR
  • I ran the relevant local checks or explained why not
  • I updated docs when behavior or setup changed
  • I added or updated tests when behavior changed, or explained why not
  • I only added comments where the logic is not obvious
  • I used Conventional Commits for commit
    messages and, when possible, the PR title

@greptile-apps

greptile-apps Bot commented Jul 1, 2026

Copy link
Copy Markdown
Contributor

Greptile Summary

This PR fixes the alignment of provider logos in the issue selector header by changing the icon's Tailwind size class from size-[90%] to size-full, making the SVG icon fill its container span instead of being constrained to 90% of it.

  • The ProviderLogo component wraps a provider icon in a fixed-size <span> (h-3.5 w-3.5 by default); the inner icon was previously rendered at 90% of that container, leaving a small visible gap — now it fills the container exactly.

Confidence Score: 5/5

Safe to merge — this is a one-line visual fix with no logic changes and no risk of regression.

The change is a single Tailwind utility class swap on an icon inside a fixed-size container. It has no effect on component logic, data flow, or behaviour — only the rendered size of the SVG icon changes, matching the intended visual design shown in the PR screenshots.

No files require special attention.

Important Files Changed

Filename Overview
apps/emdash-desktop/src/renderer/features/tasks/components/issue-selector/issue-selector.tsx Single Tailwind class change: size-[90%]size-full on the Icon inside ProviderLogo; no logic changes, no risk.

Flowchart

%%{init: {'theme': 'neutral'}}%%
flowchart TD
    A["ProviderLogo component"] --> B["outer span\nh-3.5 w-3.5 container"]
    B --> C["Icon\nsize-full (was: size-[90%])"]
    C --> D["SVG fills container 100%\n(was 90%, left visual gap)"]
Loading
%%{init: {'theme': 'base', 'themeVariables': {"darkMode": true, "background": "#0d1117", "primaryColor": "#21262d", "primaryTextColor": "#e6edf3", "primaryBorderColor": "#8b949e", "lineColor": "#8b949e", "textColor": "#e6edf3", "edgeLabelBackground": "#161b22", "actorBkg": "#21262d", "actorBorder": "#8b949e", "actorTextColor": "#e6edf3", "actorLineColor": "#8b949e", "signalColor": "#8b949e", "signalTextColor": "#e6edf3", "noteBkgColor": "#373320", "noteBorderColor": "#d4a72c", "noteTextColor": "#f0e6c0", "labelBoxBkgColor": "#21262d", "labelBoxBorderColor": "#8b949e", "labelTextColor": "#e6edf3", "loopTextColor": "#e6edf3", "activationBkgColor": "#30363d", "activationBorderColor": "#8b949e"}}}%%
flowchart TD
    A["ProviderLogo component"] --> B["outer span\nh-3.5 w-3.5 container"]
    B --> C["Icon\nsize-full (was: size-[90%])"]
    C --> D["SVG fills container 100%\n(was 90%, left visual gap)"]
Loading

Reviews (1): Last reviewed commit: "fix(issue-selector): align provider logo" | Re-trigger Greptile

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant