Skip to content

fix: add windows ssh agent pipe fallback for ssh conns#2713

Open
janburzinski wants to merge 3 commits into
mainfrom
emdash/add-windows-ssh-agent-fallback
Open

fix: add windows ssh agent pipe fallback for ssh conns#2713
janburzinski wants to merge 3 commits into
mainfrom
emdash/add-windows-ssh-agent-fallback

Conversation

@janburzinski

Copy link
Copy Markdown
Collaborator

Summary

  • add a shared ssh agent socket resolver that fallsback to the Windows openssh named pipe when SSH_AUTH_SOCK is unavailable
  • usethat fallback for agent auth and agent forwarding in SSH connection setup

@greptile-apps

greptile-apps Bot commented Jun 29, 2026

Copy link
Copy Markdown
Contributor

Greptile Summary

This PR adds a Windows fallback for SSH agent sockets. The main changes are:

  • A shared SSH agent socket resolver.
  • A Windows OpenSSH named-pipe fallback when SSH_AUTH_SOCK is missing.
  • Use of the shared resolver for agent auth and agent forwarding.
  • A forwarded platform dependency for production and test SSH connection config.
  • Tests for Windows fallback behavior and disabled-agent forwarding cases.

Confidence Score: 5/5

This looks safe to merge.

  • No blocking issues found in the changed code.

Important Files Changed

Filename Overview
apps/emdash-desktop/src/main/core/ssh/connect/ssh-connect-forward-agent.ts Moves the disabled-agent check before explicit forwarding values and uses the shared fallback resolver.
apps/emdash-desktop/src/main/core/ssh/connect/ssh-connect-auth.ts Uses the shared default agent socket resolver for agent authentication.
apps/emdash-desktop/src/main/core/ssh/connect/ssh-agent-socket.ts Adds the shared default SSH agent socket helper and Windows OpenSSH pipe constant.
apps/emdash-desktop/src/main/core/ssh/connect/resolve-ssh-connect-config.ts Adds platform to SSH connection dependencies.
apps/emdash-desktop/src/main/core/ssh/connect/production-connect-config.ts Passes process.platform into the production SSH connection resolver.
apps/emdash-desktop/src/main/core/ssh/connect/resolve-ssh-connect-config.test.ts Adds coverage for Windows fallback behavior and disabled-agent forwarding behavior.

Reviews (3): Last reviewed commit: "fix(ssh): block explicit forwarding when..." | Re-trigger Greptile

@janburzinski

Copy link
Copy Markdown
Collaborator Author

@greptileai

Comment thread apps/emdash-desktop/src/main/core/ssh/connect/ssh-connect-forward-agent.ts Outdated
@janburzinski

Copy link
Copy Markdown
Collaborator Author

@greptileai

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant