Skip to content

fix: initial prompt on windows#2711

Open
janburzinski wants to merge 6 commits into
mainfrom
emdash/keybind-injection-not-working-on-windows-p94qr
Open

fix: initial prompt on windows#2711
janburzinski wants to merge 6 commits into
mainfrom
emdash/keybind-injection-not-working-on-windows-p94qr

Conversation

@janburzinski

Copy link
Copy Markdown
Collaborator

Description

  • fix windwos stdin prompt piping
  • use powershell wrapper on windwos instead of bash piping
  • normalize extentionless npm shims to .cmd when needed

Screenshot/Recording (if applicable)

https://cap.link/cyk5zsndre368ng

Checklist
  • I kept this PR small and focused
  • I ran a self-review before opening this PR
  • I ran the relevant local checks or explained why not
  • I updated docs when behavior or setup changed
  • I added or updated tests when behavior changed, or explained why not
  • I only added comments where the logic is not obvious
  • I used Conventional Commits for commit
    messages and, when possible, the PR title

@greptile-apps

greptile-apps Bot commented Jun 29, 2026

Copy link
Copy Markdown
Contributor

Greptile Summary

This PR fixes Windows stdin prompt delivery for local agent commands. The main changes are:

  • Adds platform-aware command building for local and SSH conversations.
  • Uses a Windows PowerShell wrapper with temp-file stdin redirection.
  • Keeps POSIX stdin prompts on the existing bash pipeline.
  • Adds optional byte-based prompt spilling support and tests.

Confidence Score: 5/5

This looks safe to merge.

  • No blocking issues found in the changed code.

Important Files Changed

Filename Overview
packages/core/src/agents/plugins/helpers/standard-command.ts Adds platform-aware stdin wrapping and a Windows temp-file redirection path for stdin-pipe prompts.
apps/emdash-desktop/src/main/core/conversations/spill-large-prompt.ts Adds an optional byte threshold for prompt spilling while keeping the production default disabled.
apps/emdash-desktop/src/main/core/conversations/impl/local-conversation.ts Passes the local platform into command construction.
apps/emdash-desktop/src/main/core/conversations/impl/ssh-conversation.ts Uses the POSIX command path for SSH conversations.

Reviews (3): Last reviewed commit: "fix(agents): format windows stdin test" | Re-trigger Greptile

Comment thread apps/emdash-desktop/src/main/core/conversations/impl/local-conversation.ts Outdated
Comment thread packages/core/src/agents/plugins/helpers/standard-command.ts Outdated
@janburzinski janburzinski force-pushed the emdash/keybind-injection-not-working-on-windows-p94qr branch from 165e64a to 0117f46 Compare June 29, 2026 17:13
@janburzinski

Copy link
Copy Markdown
Collaborator Author

@greptileai

Comment thread packages/core/src/agents/plugins/helpers/standard-command.ts Outdated
@janburzinski

Copy link
Copy Markdown
Collaborator Author

@greptileai

@janburzinski janburzinski changed the title fix(agents): pipe stdin prompts on windows fix: initial prompt on windows Jun 30, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant