fix: initial prompt on windows#2711
Open
janburzinski wants to merge 6 commits into
Open
Conversation
Contributor
Greptile SummaryThis PR fixes Windows stdin prompt delivery for local agent commands. The main changes are:
Confidence Score: 5/5This looks safe to merge.
|
| Filename | Overview |
|---|---|
| packages/core/src/agents/plugins/helpers/standard-command.ts | Adds platform-aware stdin wrapping and a Windows temp-file redirection path for stdin-pipe prompts. |
| apps/emdash-desktop/src/main/core/conversations/spill-large-prompt.ts | Adds an optional byte threshold for prompt spilling while keeping the production default disabled. |
| apps/emdash-desktop/src/main/core/conversations/impl/local-conversation.ts | Passes the local platform into command construction. |
| apps/emdash-desktop/src/main/core/conversations/impl/ssh-conversation.ts | Uses the POSIX command path for SSH conversations. |
Reviews (3): Last reviewed commit: "fix(agents): format windows stdin test" | Re-trigger Greptile
165e64a to
0117f46
Compare
Collaborator
Author
Collaborator
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Screenshot/Recording (if applicable)
https://cap.link/cyk5zsndre368ng
Checklist
messages and, when possible, the PR title