fix: windows dev setup#2710
Open
janburzinski wants to merge 4 commits into
Open
Conversation
Contributor
Greptile SummaryThis PR makes the desktop app dev scripts work across platforms. The main changes are:
Confidence Score: 5/5This looks safe to merge after a small cleanup to database reset path handling.
apps/emdash-desktop/scripts/db-reset.ts
|
| Filename | Overview |
|---|---|
| apps/emdash-desktop/package.json | Replaces POSIX-only dev, clean, and reset commands with cross-platform script entries. |
| apps/emdash-desktop/scripts/clean.ts | Adds a small Node cleanup script for package-local node_modules and dist targets. |
| apps/emdash-desktop/scripts/db-reset.ts | Adds a cross-platform default dev database reset script, with a path edge case when HOME differs from Electron's app-data base. |
| pnpm-lock.yaml | Adds resolved dependency entries for cross-env and its transitive packages. |
Prompt To Fix All With AI
Fix the following 1 code review issue. Work through them one at a time, proposing concise fixes.
---
### Issue 1 of 1
apps/emdash-desktop/scripts/db-reset.ts:12
**HOME Overrides Miss Runtime DB**
When `HOME` is overridden on macOS, this script deletes `$HOME/Library/Application Support/emdash-dev`, while the Electron app's `userData` path is derived from the platform app-data directory. In that state `pnpm run db:reset` can print success while the real dev database remains unchanged, leaving the stale or corrupt DB in place.
Reviews (1): Last reviewed commit: "fix(dev): clean electron build output" | Re-trigger Greptile
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
cross-envChecklist
messages and, when possible, the PR title