fix(shortcuts): handle command palette in terminal#2701
Open
janburzinski wants to merge 6 commits into
Open
Conversation
Contributor
Greptile SummaryThis PR makes app shortcuts work while an xterm terminal is focused. The main changes are:
Confidence Score: 5/5This looks safe to merge.
|
| Filename | Overview |
|---|---|
| apps/emdash-desktop/src/renderer/lib/components/terminal-keyboard-bridge.tsx | Adds the capture-phase bridge that dispatches allowlisted shortcuts and cancels handled terminal key events. |
| apps/emdash-desktop/src/shared/shortcuts.ts | Adds the overrideTerminalFocus shortcut field and marks selected app shortcuts for terminal-focused dispatch. |
| apps/emdash-desktop/src/renderer/app/workspace.tsx | Mounts the terminal keyboard bridge with the existing workspace shortcut helpers. |
| apps/emdash-desktop/src/renderer/tests/browser/terminal-keyboard-bridge.test.tsx | Adds browser tests for handled shortcuts, duplicate registrations, terminal pass-through, and non-terminal focus. |
Reviews (3): Last reviewed commit: "fix(shortcuts): preserve app navigation ..." | Re-trigger Greptile
Collaborator
Author
Collaborator
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
on windows when you were tabbed in in a terminal the ctrl+k keybind didnt work since xterm swallowed it, this should fix it and make it work on all platforms.
Screenshot/Recording (if applicable)
https://streamable.com/z9bng0
Checklist
messages and, when possible, the PR title