fix: PR review workflow improvements by yashdev9274 · Pull Request #1223 · generalaction/emdash

yashdev9274 · 2026-03-02T14:03:42Z

Fixes for PR review workflow

…ponents - Updated Task interface to include a new 'creating' status. - Modified RightSidebar, TaskItem, and TaskTerminalPanel components to handle the new status. - Enhanced TaskItem to display a Creating... message when the task is in the 'creating' state. - Implemented optimistic UI updates in taskCreationService for immediate feedback during task creation.

- Implemented `getPullRequestDiff` and `getPullRequestBaseDiff` methods in GitHubService to retrieve diffs for pull requests. - Added IPC handlers for `github:getPullRequestDiff` and `github:getPullRequestBaseDiff` to facilitate communication between renderer and main processes. - Enhanced the preload script to expose new API methods for fetching file content from specific branches and pull request diffs. - Updated UI components to support displaying pull request diffs and improved handling of file changes in the context of PR reviews. - Introduced `OpenPrsSection` component to list open pull requests and allow users to create worktrees for review.

…ponents - Updated Task interface to include a new 'creating' status. - Modified RightSidebar, TaskItem, and TaskTerminalPanel components to handle the new status. - Enhanced TaskItem to display a Creating... message when the task is in the 'creating' state. - Implemented optimistic UI updates in taskCreationService for immediate feedback during task creation.

- Implemented `getPullRequestDiff` and `getPullRequestBaseDiff` methods in GitHubService to retrieve diffs for pull requests. - Added IPC handlers for `github:getPullRequestDiff` and `github:getPullRequestBaseDiff` to facilitate communication between renderer and main processes. - Enhanced the preload script to expose new API methods for fetching file content from specific branches and pull request diffs. - Updated UI components to support displaying pull request diffs and improved handling of file changes in the context of PR reviews. - Introduced `OpenPrsSection` component to list open pull requests and allow users to create worktrees for review.

…action#1184

vercel · 2026-03-02T14:03:46Z

Someone is attempting to deploy a commit to the General Action Team on Vercel.

A member of the Team first needs to authorize it.

greptile-apps · 2026-03-02T14:13:48Z

Greptile Summary

This PR implements PR review workflow improvements by adding new UI components and backend services to view and review GitHub pull requests directly within the application.

Major Changes:

Added two new modal components (AllChangesDiffModal and ChangesDiffModal) for viewing file diffs with Monaco editor
Implemented PR review mode in FileChangesPanel that fetches and displays PR diffs
Created OpenPrsSection component to list and open PRs for review
Added GitHub service methods to fetch PR diffs and details via GitHub CLI
Implemented optimistic UI updates for task creation with new creating status
Added support for tracking renamed files with oldPath field across git services
Integrated database persistence for PR review tasks

Issues Found:

Command injection vulnerability in githubIpc.ts where branch names are used in shell commands without escaping
Debug console.log statements left in production code that should be removed

Confidence Score: 3/5

This PR is mostly safe but has a command injection vulnerability that must be fixed before merging
The PR implements substantial new functionality with mostly clean code, but contains a critical command injection vulnerability in githubIpc.ts where branch names are used directly in shell commands without proper escaping. Additionally, debug console.log statements should be removed. The optimistic UI updates and new modal components are well-implemented with proper cleanup and error handling.
Pay close attention to src/main/ipc/githubIpc.ts for the command injection fix, and src/renderer/components/OpenPrsSection.tsx and src/renderer/components/FileChangesPanel.tsx for debug statement removal

Important Files Changed

Filename	Overview
src/main/ipc/githubIpc.ts	Added PR diff retrieval methods and database integration for PR tasks. Command injection risk exists with unescaped branch names in shell commands.
src/renderer/components/AllChangesDiffModal.tsx	New modal component for viewing all file changes with Monaco diff editor. Includes large file detection and proper cleanup.
src/renderer/components/ChangesDiffModal.tsx	New modal for viewing individual file diffs with inline comment support and save functionality.
src/renderer/components/FileChangesPanel.tsx	Added PR review mode with diff parsing and display. Integrates new diff modals and handles PR-specific UI states.
src/renderer/components/OpenPrsSection.tsx	New component for displaying open PRs with worktree creation. Contains debug console.log statements and missing cleanup on unmount.
src/renderer/lib/taskCreationService.ts	Implemented optimistic UI updates for task creation. Tasks show immediately with 'creating' status before worktree creation completes.

Sequence Diagram

sequenceDiagram
    participant User
    participant OpenPrsSection
    participant GitHubIPC
    participant GitHubService
    participant Database
    participant FileChangesPanel
    participant DiffModal
    
    User->>OpenPrsSection: Click "Review PR"
    OpenPrsSection->>GitHubIPC: githubCreatePullRequestWorktree()
    GitHubIPC->>GitHubService: ensurePullRequestBranch()
    GitHubService-->>GitHubIPC: Branch created
    GitHubIPC->>Database: saveTask(taskInfo)
    GitHubIPC-->>OpenPrsSection: {task, worktree}
    OpenPrsSection->>User: Open task in UI
    
    User->>FileChangesPanel: View task with prNumber
    FileChangesPanel->>GitHubIPC: githubGetPullRequestBaseDiff()
    GitHubIPC->>GitHubService: getPullRequestDetails()
    GitHubService-->>GitHubIPC: {baseRefName, headRefName}
    GitHubIPC->>GitHubIPC: execSync git diff
    GitHubIPC-->>FileChangesPanel: {diff, baseBranch, headBranch}
    FileChangesPanel->>FileChangesPanel: parseDiffToFileChanges()
    FileChangesPanel-->>User: Display PR diff files
    
    User->>DiffModal: Click "View Full PR Diff"
    DiffModal->>DiffModal: Load Monaco editor with diffs
    DiffModal-->>User: Show interactive diff view

_{Last reviewed commit: b20865f}

greptile-apps

_{21 files reviewed, 4 comments}

_{Edit Code Review Agent Settings | Greptile}

src/main/ipc/githubIpc.ts

greptile-apps · 2026-03-02T14:13:54Z

src/renderer/components/OpenPrsSection.tsx

+      console.log('Review PR result:', result);
+
+      if (result.success && result.task) {
+        console.log('Calling onOpenTask with:', result.task);


Remove debug console.log statements before merging to production

Suggested change

console.log('Review PR result:', result);

if (result.success && result.task) {

console.log('Calling onOpenTask with:', result.task);

if (result.success && result.task) {

const taskWithPr = {

greptile-apps · 2026-03-02T14:13:55Z

src/renderer/components/OpenPrsSection.tsx

+          description: `${errorMessage}. Opening PR on GitHub instead.`,
+          variant: 'destructive',
+        });
+        console.log('Falling back to GitHub, success:', result.success, 'error:', result.error);


Remove debug console.log statement

Suggested change

console.log('Falling back to GitHub, success:', result.success, 'error:', result.error);

window.electronAPI.openExternal(pr.url);

_{Note: If this suggestion doesn't match your team's coding style, reply to this and let me know. I'll remember it for next time!}

greptile-apps · 2026-03-02T14:13:56Z

src/renderer/components/FileChangesPanel.tsx

+
+  useEffect(() => {
+    console.log('PR Review Check:', { resolvedPrNumber, safeTaskPath });
+    if (resolvedPrNumber && safeTaskPath) {
+      setIsLoadingPrDiff(true);
+      window.electronAPI
+        .githubGetPullRequestBaseDiff({
+          worktreePath: safeTaskPath,
+          prNumber: resolvedPrNumber,


Remove debug console.log statements

Suggested change

useEffect(() => {

console.log('PR Review Check:', { resolvedPrNumber, safeTaskPath });

if (resolvedPrNumber && safeTaskPath) {

setIsLoadingPrDiff(true);

window.electronAPI

.githubGetPullRequestBaseDiff({

worktreePath: safeTaskPath,

prNumber: resolvedPrNumber,

if (resolvedPrNumber && safeTaskPath) {

setIsLoadingPrDiff(true);

window.electronAPI

.githubGetPullRequestBaseDiff({

_{Note: If this suggestion doesn't match your team's coding style, reply to this and let me know. I'll remember it for next time!}

yashdev9274 · 2026-03-02T17:36:21Z

hey @arnestrickmann @rabanspiegel fix this #1184
pls merge it, so I can look after new issues & features

yashdev9274 · 2026-03-03T11:18:44Z

guys @arnestrickmann @rabanspiegel any update on my PR ??

rabanspiegel · 2026-03-03T18:45:15Z

we'll get to reviewing today! @yashdev9274 -- thank you for this!

yashdev9274 · 2026-03-03T18:48:01Z

we'll get to reviewing today! @yashdev9274 -- thank you for this!

sure 👍🏻

arnestrickmann · 2026-03-03T21:40:02Z

going through some bigger changes first, will update you as soon as i review your PR.
Thank you for contributing

arnestrickmann · 2026-03-04T22:59:24Z

Hi @yashdev9274, thanks again for opening this pr and for picking this issue.

A user that requested this feature also let us know that it would make sense to be able to filter through the PRs as, for example, their team has 140 open PRs.

It would also make sense if, per default, we only render like the latest 10 and then enable the user to 1) search 2) filter and 3) expand the initially rendered amount of PRs.

arnestrickmann · 2026-03-06T04:54:01Z

@yashdev9274 hey, what do you think?

yashdev9274 · 2026-03-06T12:28:59Z

@yashdev9274 hey, what do you think?

yes, sorry i missed it, i was looking at #1228
ill get back to work on #1223 once i finish this resp one.

also is there any slack grp other than discord, which i can join so that i don't miss the updates !?

arnestrickmann · 2026-03-06T18:34:52Z

@yashdev9274 hey, thanks for the message,

we only have the discord server for now for communication with contributors.

What is your discord handle? then i can set up a shared chat with you, my co founder and me

yash dewasthale and others added 11 commits March 1, 2026 01:24

Merge branch 'generalaction:main' into main

436436b

Merge branch 'generalaction:main' into main

c1402e9

Merge remote-tracking branch 'upstream/main'

f324d1b

Merge branch 'main' of github.com:yashdev9274/emdash

2071062

Merge branch 'main' of github.com:yashdev9274/emdash

1169230

Merge upstream/main into fork main - resolve conflicts for PR general…

4c59499

…action#1184

fix: PR review workflow improvements

b20865f

yashdev9274 mentioned this pull request Mar 2, 2026

feat: add full PR review workflow #1184

Closed

greptile-apps bot reviewed Mar 2, 2026

View reviewed changes

	console.log('Falling back to GitHub, success:', result.success, 'error:', result.error);
	window.electronAPI.openExternal(pr.url);

Conversation

yashdev9274 commented Mar 2, 2026

Uh oh!

vercel bot commented Mar 2, 2026

Uh oh!

greptile-apps bot commented Mar 2, 2026

Greptile Summary

Confidence Score: 3/5

Important Files Changed

Sequence Diagram

Uh oh!

greptile-apps bot left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

greptile-apps bot Mar 2, 2026

Choose a reason for hiding this comment

Uh oh!

greptile-apps bot Mar 2, 2026

Choose a reason for hiding this comment

Uh oh!

greptile-apps bot Mar 2, 2026

Choose a reason for hiding this comment

Uh oh!

yashdev9274 commented Mar 2, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

yashdev9274 commented Mar 3, 2026

Uh oh!

rabanspiegel commented Mar 3, 2026

Uh oh!

yashdev9274 commented Mar 3, 2026

Uh oh!

arnestrickmann commented Mar 3, 2026

Uh oh!

arnestrickmann commented Mar 4, 2026

Uh oh!

arnestrickmann commented Mar 6, 2026

Uh oh!

yashdev9274 commented Mar 6, 2026

Uh oh!

arnestrickmann commented Mar 6, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

yashdev9274 commented Mar 2, 2026 •

edited

Loading