Fix for Symfony 3.4.0 #446
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TwigRendererInterface is deprecated. Symfony 3.4.0 doesn't use it anymore, so an error is thrown when calling this constructor.
|
Tested the change myself, fixes described issue with Symfony 3.4. Recommend to accept the MR. |
|
@noemiperez Not sure if you still need this as your comment is from 2017, but I've implemented this fix in my fork: https://github.com/wowpatrick/GenemuFormBundle |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TwigRendererInterface is deprecated. Symfony 3.4.0 doesn't use it anymore, so an error is thrown when calling this constructor.