Make JobHandle pure struct for stackalloc compatibility #34
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
genaray
approved these changes
Feb 17, 2024
Comment on lines
+11
to
+21
| /// <summary> | ||
| /// Assigns schedulers an ID, and a cache of tracked jobs. | ||
| /// This way, we can store a Scheduler and a Job on a JobHandle by integer ID, | ||
| /// so that stackalloc JobHandle[] can work. Otherwise the managed types would prevent it. | ||
| /// </summary> | ||
| // A dictionary is OK because we only add when we initialize a new scheduler. | ||
| // It otherwise doesn't use memory. | ||
| // Accesses could be sliiiightly faster if we used an array and recycled IDs but not appreciably so, | ||
| // particularly for the overhead it would involve. | ||
| private static readonly Dictionary<int, (JobScheduler Scheduler, Job[] JobIds)> | ||
| _schedulerCache = []; |
There was a problem hiding this comment.
Yep thats right. Im fine here with a dictionary. Just wondering how fast or slow it would be to use an array instead ^^ But that's not a high priority here.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #31 by adding a caching system to associate Job and Scheduler classes to a JobHandle that just stores integer IDs.
Ran a few benchmarks; no significant performance impact; it only has to do a couple extra dictionary/array lookups per Schedule and Complete call.