Skip to content

Conversation

Copy link

Copilot AI commented Nov 3, 2025

Addresses review feedback on #1332 to rename the perpetualModify enum case to perpetualModifyPosition for consistency with related perpetual transaction types.

Changes

  • Renamed TransactionType.perpetualModifyTransactionType.perpetualModifyPosition in generated type definition
  • Updated all references across 12 files:
    • Transaction filtering and view models
    • Transfer confirmation UI sections
    • Transaction header builders and view models
    • Test cases
// Before
case perpetualModify

// After  
case perpetualModifyPosition

This aligns naming with perpetualOpenPosition and perpetualClosePosition, making the enum value more descriptive of its purpose.


💬 We'd love your input! Share your thoughts on Copilot coding agent in our 2 minute survey.

Co-authored-by: gemcoder21 <104884878+gemcoder21@users.noreply.github.com>
Copy link
Author

Copilot AI commented Nov 3, 2025

Just as a heads up, I was blocked by some firewall rules while working on your feedback. Expand below for details.

Warning

Firewall rules blocked me from connecting to one or more addresses (expand for details)

I tried to connect to the following addresses, but was blocked by firewall rules:

  • just.systems
    • Triggering command: curl --proto =https --tlsv1.2 -sSf https://just.systems/install.sh (dns block)

If you need me to access, download, or install something from one of these locations, you can either:

Copilot AI changed the title [WIP] Update autoclose feature based on review comments Rename perpetualModify to perpetualModifyPosition for clarity Nov 3, 2025
Copilot AI requested a review from gemcoder21 November 3, 2025 18:34
Copilot finished work on behalf of gemcoder21 November 3, 2025 18:34
@gemcoder21 gemcoder21 marked this pull request as ready for review November 3, 2025 19:12
@gemcoder21 gemcoder21 merged commit 84b4503 into 1223-autoclose-feature Nov 3, 2025
@gemcoder21 gemcoder21 deleted the copilot/sub-pr-1332 branch November 3, 2025 19:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants