Add enable push notifications during first onboarding #1343
Conversation
Introduced EnablePushNotificationsScene and its view model to prompt users to enable push notifications during onboarding. Integrated the scene into RootScene and RootSceneViewModel, showing it when appropriate based on user preferences. Updated dependencies and tests to support the new feature. Also added a bell emoji to the Emoji struct and removed the unused EmojiView.swift.
Summary of ChangesHello @DRadmir, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request enhances the user onboarding experience by integrating a dedicated screen to encourage new users to enable push notifications. This screen appears after a new wallet is created, ensuring timely engagement with notification settings. The changes also include updates to the application's core logic to manage and display this new notification prompt effectively, improving overall user interaction and ensuring critical wallet activity alerts are received. Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
…enable-push-notifications-during-first-onboarding
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request introduces a screen to prompt users to enable push notifications during the initial wallet setup. The implementation is well-structured, adding a new SwiftUI scene and view model, and integrating it into the main application flow. My review includes suggestions to align with modern SwiftUI practices for state management, and to improve localization by moving hardcoded user-facing strings into resource files. These changes will enhance the code's maintainability and provide a better experience for international users.
Features/Onboarding/Sources/ViewsModels/EnablePushNotificationsViewModel.swift
Outdated
Show resolved
Hide resolved
Features/Onboarding/Sources/Scenes/EnablePushNotificationsScene.swift
Outdated
Show resolved
Hide resolved
Features/Onboarding/Sources/Scenes/EnablePushNotificationsScene.swift
Outdated
Show resolved
Hide resolved
…enable-push-notifications-during-first-onboarding
Replaces the custom UI in EnablePushNotificationsScene with the reusable InfoSheetScene, simplifying the view and centralizing presentation logic. Updates dependencies and view model to support InfoSheet integration.
| import Localization | ||
| import PrimitivesComponents | ||
|
|
||
| public struct EnablePushNotificationsScene: View { |
There was a problem hiding this comment.
EnablePushNotificationsScene I think think we need another scene, should be easily integrated into InfoSheet with actions so we can customize different presenting messages
Gem/Scenes/RootScene.swift
Outdated
| image: SystemImage.network | ||
| ) | ||
| ) | ||
| .sheet(isPresented: $model.isPresentingEnablePushNotifications) { |
There was a problem hiding this comment.
should be generic for info sheet, so we can ask to enable face id, notifications and many others
…enable-push-notifications-during-first-onboarding
Moved push notification onboarding logic to a generic InfoSheetActionScene and related types. Introduced InfoSheetActionType and InfoSheetActionable protocol for extensibility. Updated RootScene and RootSceneViewModel to use onboardingPresenter and present InfoSheet actions. Added OnboardingPresenter and corresponding tests. Updated dependency injection and factories to support new onboarding flow.
Summary
EnablePushNotificationsScenethat appears after wallet creation during onboardingTODO:
Closes #1284
##Screenshots
Simulator.Screen.Recording.-.iPhone.17.-.2025-10-28.at.16.24.45.mov