Search as tab #1312
Draft
Search as tab #1312
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Introduces a dedicated SearchNavigationStack and adds a new 'search' tab to the app, leveraging iOS 16+ TabView features. Removes legacy search presentation logic from WalletScene and WalletSceneViewModel, updates navigation state management, and refactors related view models and navigation stacks for improved modularity and maintainability.
Introduces WalletNavigationFlowModifier to encapsulate navigation logic for wallet-related flows, reducing duplication in WalletNavigationStack and SearchNavigationStack. Refactors WalletSearchSceneViewModel to support new navigation bindings and wallet changes, and updates MainTabView and related navigation stacks to use the new modifier and view model structure. Cleans up unused environment variables and streamlines navigation and sheet presentation logic.
Simplified the ios26TabView by removing the unnecessary #available(iOS 26, *) check, as the method itself is already marked with @available(iOS 26.0, *). This streamlines the code and improves readability.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.