[FIX] Use deepcopy for options and add example.mle test file #16
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Leguark
changed the title
4 tasks
Leguark
added a commit
to gempy-project/gempy
that referenced
this pull request
Jun 13, 2025
# Description New PR for the evaluating the computation time for custom grids. Test now includes model computation for pure model, after adding a topography and using the `compute_model_at` function with 1000 random points. I removed the test that deep created to clean up. Just fyi - here are the resulting times on my computer:  Added a warning message to `compute_model_at` function to alert users about potential side effects when setting a custom grid and computing the model. Modified the `set_custom_grid` function to include a `reset` parameter, which is now set to `True` in `compute_model_at` to ensure proper grid reset. Removed code in the `solutions` setter that was setting solutions per group, as this was causing issues with the custom grid functionality. Added comprehensive tests to measure and compare computation times across different grid configurations: - Dense grid computation (with consistency checks) - Topography grid vs dense grid computation - Custom grid computation with random coordinates # Checklist - [x] My code uses type hinting for function and method arguments and return values. - [x] I have created tests which cover my code. - [x] The test code either 1. demonstrates at least one valuable use case (e.g. integration tests) or 2. verifies that outputs are as expected for given inputs (e.g. unit tests). - [x] New tests pass locally with my changes. Relates to: gempy-project/gempy_engine#16 (comment)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[BUG] Fix dual contouring deepcopy and remove redundant code
copy.copywithcopy.deepcopyinmulti_scalar_dual_contouring.pyto ensure proper isolation of options when modifying evaluation parametersraw_arrays_solution.pythat were handling unneeded block solution types[BUG] Dual contouring was switching compute grads on for the original geomodel object