[WIP] Fix pd warning #683
Merged
[WIP] Fix pd warning #683
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Japhiolite
reviewed
Mar 18, 2022
Collaborator
Japhiolite
left a comment
Japhiolite
left a comment
There was a problem hiding this comment.
Have you tested if this works? I think, if inplace is removed, the change has to be assigned to a variable.
Contributor
Author
|
Haven't tested it yet......will do so soon |
Japhiolite
requested changes
Mar 22, 2022
Collaborator
Japhiolite
left a comment
Japhiolite
left a comment
There was a problem hiding this comment.
Tested the proposed changes, which yield expected errors. Removing the deprecated inplace argument must go hand in hand with assigning the change, i.e.
self._surface_points.df['surface'] = self._surface_points.df['surface'].cat.add_categories(surface_list)
self._orientations.df['surface'] = self._orientations.df['surface'].cat.add_categories(surface_list)should do the trick.
Contributor
Author
|
Thanks for testing! I will change the PR accordingly and try to fix the other obsolete inplace places as well |
Japhiolite
approved these changes
Mar 22, 2022
Contributor
Author
|
fixes #682 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Please include a summary of the changes.
Relates to #682