-
Notifications
You must be signed in to change notification settings - Fork 1.4k
Mfma matrix core timing #1700
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Mfma matrix core timing #1700
Conversation
Needs to be merged in after #1693 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Since Vishnu already integrated Nagendra's patches in #1693, please remove those from this patch before we review.
859071a
to
a8f1053
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Few small things, but overall nice job!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is mostly good, thanks! I only have one additional comment on top of Matt's comments.
@mjkpolo Hello, thank you for your contribution! Could you give an update on the status of this PR? Also, if you are able to make the changes requested within the next day or so/by the end of this week, we may be able to get this PR into the staging branch. |
@mjkpolo is working towards an ISCA submission, so my guess is he won't be able to address these comments in the timeline you provided. |
Should I just add a commit with the changes? It seems like we just want comments and an assert? |
a8f1053
to
439b3f3
Compare
A lookup table is used with values taken from the mi200 and mi300 ISA specifying how long a SIMD's matrix core unit will be consumed by MFMAs. This time can be adjusted for all MFMAs using the --mfma-scale parameter.
439b3f3
to
95c3a3c
Compare
Thanks @abmerop ! I also fixed the print info. |
A lookup table is used with values taken from the mi200 and mi300 ISA
specifying how long a SIMD's matrix core unit will be consumed by MFMAs.
This time can be adjusted for all MFMAs using the --mfma-scale parameter.