Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Report migration count and object count as metrics #8369

Merged
merged 1 commit into from
Feb 21, 2025
Merged

Report migration count and object count as metrics #8369

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Report migration count and object count as metrics
  • Loading branch information
@msullivan
msullivan committed Feb 21, 2025
commit 29a7979abca079304bcab48d561973036f8c2bcc
6 changes: 6 additions & 0 deletions edb/server/compiler/ddl.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1230,6 +1230,7 @@ def _reset_schema(
s_func.Function: 'function',
s_indexes.Index: 'index',
s_scalars.ScalarType: 'scalar',
s_migrations.Migration: 'migration',
}


Expand Down Expand Up @@ -1302,6 +1303,11 @@ def _track(key: str) -> None:
and len(obj.get_bases(schema).objects(schema)) > 1
):
_track('multiple_inheritance')
elif (
isinstance(obj, s_objtypes.ObjectType)
and obj.is_material_object_type(schema)
):
_track('object_type')
elif (
isinstance(obj, s_scalars.ScalarType)
and obj.is_enum(schema)
Expand Down