Modify email normalization to strip + and .
#53
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
+suffixes are removed for all emails except for @users.noreply.github.com special addresses, in which case prefixes+ are removed as the usernames are used by the CLA bot. Dot characters are removed from gmail.com addresses where they are irrelevant. Fixes geldata#51
|
Tested on python/cpython#22694. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
+suffixes are removed for all emails except for @users.noreply.github.com special addresses, in which case prefixes+ are removed as the usernames are used by the CLA bot.
Dot characters are removed from gmail.com addresses where they are irrelevant.
Note: changing
ContributorLicenseAgreement.normalized_emailto actually use thenormalize_email()function is left in a separate commit because an action that deduplicates the database might be necessary to apply the migration successfully. A script to do that is added toscripts/.Fixes #51