Skip to content

Conversation

@gelanivishal
Copy link
Owner

Original Pull Request

magento#15322
Added zero index to array signifier in searchCriteria parameters builder

Description

This fix allows to generate correct response when user want to test method with some search criteria parameters in Swagger.

Fixed Issues (if relevant)

  1. Magento REST API Schema (Swagger) is not compatible with Search Criteria magento/magento2#11477: Magento REST API Schema (Swagger) is not compatible with Search Criteria

Manual testing scenarios

  1. Open Swagger
  2. In method "catalogProductRepositoryV1" fill in "Parameters" tab values for searchCriteria which use "filterGroups" key
  3. Click "Try it out!"
  4. Check if Response Code is 200

Contribution checklist

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds on Travis CI are green)

@gelanivishal gelanivishal merged commit 5816a52 into 2.3-develop Jun 8, 2018
gelanivishal pushed a commit that referenced this pull request Oct 10, 2018
Accepted Public Pull Requests:
 - magento#17960: [Forwardport] Move functions.php into Framework (by @fooman)
 - magento#17765: [Forwardport] Clean code (by @nmalevanec)
 - magento#17768: [Forwardport] Fix proxy generation return type (by @nmalevanec)
 - magento#17941: [Forwardport] Sales: Add unit test for validator model class (by @dmytro-ch)
 - magento#17946: [2.3]  changed intval($val) to (int) $val, since `(int) $val ` is faster. (by @TBlindaruk)
 - magento#17938: Replace sort callbacks to spaceship operator (by @mage2pratik)
 - magento#17922: [Forwardport] API-functional test for Search (by @mage2pratik)
 - magento#17921: [Forwardport] Remove leading Countrycode from EU-VAT-Numbers (by @mage2pratik)
 - magento#17874: [Forwardport] Fix - Next Page button triggered when filtering Customer grid (by @ronak2ram)
 - magento#17911: [Forwardport] Resolved : Wishlist icon cut on Shopping cart page in mobile view magento#17851 #27 (by @hitesh-wagento)
 - magento#17848: Fix for invalid JSON if image label contains HTML markup, example " (by @jeroenschipper)
 - magento#17832: [Forwardport] Fix translation issue (by @nmalevanec)
 - magento#17837: [Forwardport] [Search] Unit test for SynonymAnalyzer model (by @furseyev)
 - magento#17829: [Forwardport] CSS load order incorrect using default_head_blocks.xml magento#1821 (by @nmalevanec)
 - magento#17750: [Forwardport] Unable to change attribute type from swatch (by @nmalevanec)
 - magento#17650: Use route ID when creating secret keys in backend menus instead of route name (by @lfolco)


Fixed GitHub Issues:
 - magento#17789: Next Page button triggered when filtering Customer grid (reported by @lucasjor-summa) has been fixed in magento#17874 by @ronak2ram in 2.3-develop branch
   Related commits:
     1. 92c1aa4
     2. a2993a5
     3. c580a46

 - magento#17851: Wishlist icon cut on Shopping cart page in mobile view (reported by @hitesh-wagento) has been fixed in magento#17911 by @hitesh-wagento in 2.3-develop branch
   Related commits:
     1. f0b5ecc

 - magento#1821: CSS load order incorrect using default_head_blocks.xml (reported by @chicgeek) has been fixed in magento#17829 by @nmalevanec in 2.3-develop branch
   Related commits:
     1. d3e24ed
     2. fe6c96f

 - magento#9307: Color attribute taking swatch instead of Drop down option for configurable options, (reported by @vishveskrish) has been fixed in magento#17750 by @nmalevanec in 2.3-develop branch
   Related commits:
     1. 0f28b61
     2. d159921

 - magento#9923: Upgrading to 2.1.7 changed dropdown attributes to swatches (reported by @roseofgold) has been fixed in magento#17750 by @nmalevanec in 2.3-develop branch
   Related commits:
     1. 0f28b61
     2. d159921

 - magento#11403: Product Attributes Not Updating on Frontend (reported by @rbur0425) has been fixed in magento#17750 by @nmalevanec in 2.3-develop branch
   Related commits:
     1. 0f28b61
     2. d159921

 - magento#11703: Changing Swatches to Drop-down does not remove swatches from existing products (reported by @expgabe) has been fixed in magento#17750 by @nmalevanec in 2.3-develop branch
   Related commits:
     1. 0f28b61
     2. d159921

 - magento#12695: Unable to change attribute type from swatch to dropdown  (reported by @alena-marchenko) has been fixed in magento#17750 by @nmalevanec in 2.3-develop branch
   Related commits:
     1. 0f28b61
     2. d159921

 - magento#7557: Backend Security key broken for controllers with frontname not equal to route ID (reported by @AlexandreKhayrullin) has been fixed in magento#17650 by @lfolco in 2.3-develop branch
   Related commits:
     1. 2662dfa
     2. a0dfb6d
     3. 35eba04
     4. 600a185
     5. 062286e
     6. c3d700a
     7. be7c961
     8. fa8a222
     9. b738ce6
     10. af3507a
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants