FIX: Fixed variable shadowing and enhanced gitignore

[venarius]

Hey 👋

Just came across this project and really like it so far. Trying to get a bit more involved in here. For starters, there were some warning: shadowing outer local variable warnings while running the tests. I fixed the ones which belong to gel.

Also added .idea and .ruby-gemset to gitignore

[matthewd]

I had taken the perspective that as newer rubies don't warn on that code anymore, it's fine as is... but I'm open to being persuaded that we should still change it to be warning-free on all versions we support. Given that previous context, do you think we should still change it?

As for the ignore entries, being application-specific instead of project-specific, they seem like they'd be better suited to a locally-configured universal gitignore. Otherwise the file becomes a list of every program anyone's run against the repository, which can look progressively less-great over time.

[venarius]

I am open to any style specific changes but shadowing on variables should be fixed from my point of view since it can also confuse a lot of possible contributors.

[venarius]

As to the gitignore changes, things like .ruby-gemset or .idea are very common things to ignore on a ruby project, since most developers probably use some kind of gemset management and a jetbrains tool for development.

Discourse for example has the same in their gitignore.

For me it was either adding it to the gitgnore or needing to remind some devs that they just accidentally added their .idea folder in their PR.

But it really is just my point of view :)

[matthewd]

Shadows fixed by #75; I couldn't merge this one because of the ignore changes

Sorry to close this after leaving it in limbo for so long 😢