Skip to content

Fix ansible apt parameters. #3

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 28, 2015
Merged

Conversation

thom8
Copy link
Contributor

@thom8 thom8 commented Jun 28, 2015

Fixed up the apt params based on the Ansible docs - http://docs.ansible.com/apt_module.html

@geerlingguy
Copy link
Owner

Looks good! Test failures are unrelated, due to Ansible version currently being used by Travis when running tests.

geerlingguy added a commit that referenced this pull request Jun 28, 2015
PR #3: Adjust apt parameters to follow latest Ansible standards.
@geerlingguy geerlingguy merged commit 3944c21 into geerlingguy:master Jun 28, 2015
geerlingguy added a commit that referenced this pull request Jun 28, 2015
@geerlingguy
Copy link
Owner

Also, of note, it seems the convention of using present over installed for packaging modules has been a slow change over the past year or so, but I couldn't find the specific time when the change was made official in the docs. Up until recently, I remembered seeing installed as one of the documented options.

It should still work, though, right?

@thom8
Copy link
Contributor Author

thom8 commented Jun 29, 2015

I've found references to both "installed" & "present" so I'd assume both will work.
"installed" is probably still supported for backwards compatibility but "present" is the currently documented state -- http://docs.ansible.com/apt_module.html#options

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants