Fix #274: Always register the mysql_cli_version variable #275
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
kietnguyen
pushed a commit
to kietnguyen/ansible-role-mysql
that referenced
this pull request
Apr 9, 2020
…egister-mysql-version Fix geerlingguy#274: Always register the mysql_cli_version variable
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes #274 caused by my previous PR #273. Since the
my.cnf.j2template now uses themsql_cli_versionvar to determine if some settings shouldn't be there, it has to always run in normal mode.Unfortunately when running this role in check mode on a clean host, this task will fail because the
mysqlbinary won't initally be available. However, even before PR #273, this role failed in check mode on a clean host onSet ownership on error log filebecause the file wouldn't exist, so I hope the earlier failure now isn't unexpected.