Skip to content

Conversation

straysheep-dev
Copy link

After seeing how Pop!_OS and Linux Mint were supported, it looks like the same can be done for Kali using a separate variable for the release string here:

docker_apt_ansible_distribution_release: "{{ 'bookworm' if ansible_distribution in ['Kali'] else ansible_distribution_release }}"

...and replacing the few instances of ansible_distribution_release with that new variable.

There may be a better way to do this since bookworm will need updated with each Debian major release. However it's infrequent enough that it may be acceptable for now, similar to the GPG key checksum being a static value.

@clem9669
Copy link

clem9669 commented Feb 6, 2025

Hey @straysheep-dev @geerlingguy 👋

This looks great ! I hope this will be merge soon 🙏

Cheers

@mr-pmillz
Copy link

mr-pmillz commented Mar 1, 2025

When will this PR be merged? @clem9669
I'm getting failing builds for installing docker on Kali via this role due to the wrong url getting set for this task: https://github.com/geerlingguy/ansible-role-docker/blob/master/tasks/setup-Debian.yml#L40

this causes it to fall back to attempting to download docker gpg key from a non-existent url "https://download.docker.com/linux/kali/gpg" and piping it to the now deprecated apt-key command.
starting at Debian 11 and Ubuntu 20.10, apt-key is now deprecated and it will no longer be available after Debian 11 and Ubuntu 22.04
https://community.learnlinux.tv/t/how-to-apt-key-is-deprecated-heres-how-to-fix-it/489

@straysheep-dev straysheep-dev force-pushed the straysheep-dev/patch-kali-support branch from 146d6b1 to 22f3a4c Compare August 24, 2025 21:23
@straysheep-dev
Copy link
Author

straysheep-dev commented Aug 24, 2025

Updated this to work with the new deb822_repository module, and use Debian 13's trixie instead of 12's bookworm for Kali.

I also noticed the refactor may have accidentally removed support for POP!_OS and Linux Mint by pointing directly to ansible_facts.distribution and not docker_apt_ansible_distribution here. There may be a plan to handle these cases better, but if not, I wanted to mention this. 👍

@straysheep-dev straysheep-dev force-pushed the straysheep-dev/patch-kali-support branch from 22f3a4c to 08314fb Compare August 29, 2025 04:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants