Open
Conversation
Update required drush version from 11 to 12 (see: https://www.drupal.org/node/3403057) Add check for drush binary file existence and replace "when" conditional for drush installation. This works better with progressive playbook runs (when you run them after each change) in which composer json file already exists.
Author
|
Pipeline failed but its seems that not because of my changes. |
Owner
|
Thanks and yeah, I need to fix up a couple of other issues there. I'll try to loop this into a few other fixes in my next pass on the book, so I can sync the manuscript to this repo. |
|
Thankyou for the fix. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Update required drush version from 11 to 12 (see: https://www.drupal.org/node/3403057)
Add check for drush binary file existence and replace "when" conditional in drush installation task. This works better with progressive playbook runs (when you run playbook after each change) in which composer json file already exists. Offcourse its still not perfect as it checks only file's existence, without checking it's version. Yet for learning purposes i think its a sufficient compromise between reliability and simplicity.