Skip to content

Commit

Permalink
Replace nvm/asdf with native CircleCI node installation (readthedocs#…
Browse files Browse the repository at this point in the history
…10174)

I'm not really sure how/why this was working. It seems this was using
some mix of asdf and nvm (??).

I removed some hacks and replaced it with the node orb that we're using
to install Node in other repositories.
  • Loading branch information
agjohnson committed Mar 21, 2023
1 parent c36fc57 commit 385398e
Show file tree
Hide file tree
Showing 2 changed files with 4 additions and 21 deletions.
12 changes: 4 additions & 8 deletions .circleci/config.yml
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,7 @@ version: 2.1

orbs:
codecov: codecov/codecov@3.2.2
node: circleci/node@5.1.0

jobs:
tests:
Expand Down Expand Up @@ -37,21 +38,16 @@ jobs:
checks:
docker:
- image: 'cimg/python:3.10'
environment:
NODE_VERSION: 10.17.0
steps:
- checkout
- run: git submodule sync
- run: git submodule update --init
- run: pip install --user 'tox<5'
- run: tox -e pre-commit
- run: tox -e migrations
- run: scripts/circle/install_node.sh
- run:
name: Add node to the path
command: |
echo 'export PATH=~/.nvm/versions/node/v${NODE_VERSION}/bin:$PATH' >> $BASH_ENV
source $BASH_ENV
- node/install:
node-version: '10.17.0'
- run: npm ci
- run: tox -e eslint

workflows:
Expand Down
13 changes: 0 additions & 13 deletions scripts/circle/install_node.sh

This file was deleted.

0 comments on commit 385398e

Please sign in to comment.