Python 3 Compatibility - Rebased Fork

[rakanalh]

This PR is a rebase of @avendael's work on Python3 compatibility to the latest version of develop.

Thank you @geeknam, @avendael

[coveralls]

Coverage decreased (-9.49%) to 81.92% when pulling 10e5163 on rakanalh:master into 0af0b12 on geeknam:master.

[coveralls]

Coverage decreased (-5.99%) to 85.42% when pulling e731ecf on rakanalh:master into 0af0b12 on geeknam:master.

[landscape-bot]

Repository health decreased by 7% when pulling e731ecf on rakanalh:master into 0af0b12 on geeknam:master.

• 5 new problems were found (including 2 errors and 3 code smells).
• No problems were fixed.

[rakanalh]

@geeknam did you get the chance to review this?

[dotpot]

👍 I was thinking about doing similar PR. :))

[geeknam]

Thanks guys, can we get the coverage & health up? Who wants to volunteer to do this? :)

[rakanalh]

I believe the priority should be making a release rather than waiting for people to improve health indicator & tests. All current tests pass so the library should be good to go for a release with this branch.

This is my 0.02

[geeknam]

Thanks for your input @rakanalh. Landscape caught an undefined variable urllib https://landscape.io/diff/148815

[landscape-bot]

Repository health decreased by 1% when pulling d6d1e55 on rakanalh:master into 0af0b12 on geeknam:master.

• 2 new problems were found (including 0 errors and 2 code smells).
• No problems were fixed.

[geeknam]

In my opinion, using requests and replacing urllib and urllib2 will definitely be a good move here.

Benefits:

• requests is python 3 compatible
• using requests would make the code cleaner
• everyone is familiar with requests, requests is more human friendly

[rakanalh]

I agree... but many people along with myself need this to be Py3 compliant as soon as possible.

As for requests, i also agree. I prefer using requests over urllib. Could you leave this as an open issue for someone to pick up and create a PR for that?

[coveralls]

Coverage decreased (-5.66%) to 85.76% when pulling d6d1e55 on rakanalh:master into 0af0b12 on geeknam:master.

[geeknam]

#60 fixes this