Remove unecessary line of code and variable, and tidy up comments and syntax. #36
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GoudaOnBeamPro
changed the title
added 8 commits
February 14, 2016 01:39
Line 21. Combined open() with read() in one line, saving a variable and a line
|
I think I went a little crazy on that... sorry if that is too much. |
geekcomputers
added a commit
that referenced
this pull request
Feb 16, 2016
Remove unecessary line of code and variable, and tidy up comments and syntax.
|
No worries, thanks for making the improvements Cheers On 14 Feb 2016, at 09:16, Jared Manning notifications@github.com wrote:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm still learning Git, so sorry about the two different and unrelated commits in this.
The first one (70271c5) just tidies up the comments and syntax a bit in backup_automater_services.py. I added spaces on either side of some equal signs to make them easier to read.
The second one (0f47eb3) removes a line of code and a variable in check_file.py by combining the line
with the line below to make it
Nothing crazy. Just some thoughts I had while checking these out. I'm currently learning Python and Git, so bear with me if I'm doing something wrong here.
I also did the same thing for check_for_sqlite_files.py in 903d620.
Thanks for considering this!