Skip to content

Bug fixes and completed skeletons for ui, Chart #6

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Nov 14, 2023
Merged

Bug fixes and completed skeletons for ui, Chart #6

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
cca4059
Replaced callback and project order; fixes #5
lopezvoliver Nov 14, 2023
92bf155
Better Export.image region validation
lopezvoliver Nov 14, 2023
6d2775f
set NODE_ENV in package.json
lopezvoliver Nov 14, 2023
9a24a85
Completed skeleton for ui
lopezvoliver Nov 14, 2023
898c7a6
Updated changelog
lopezvoliver Nov 14, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 7 additions & 1 deletion CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,4 +19,10 @@

## v0.1.1

- Bug fix [issue #3](https://github.com/gee-community/eetasks/issues/3)
- Bug fix [issue #3](https://github.com/gee-community/eetasks/issues/3)

## v0.1.2

- Bug fix [issue #5](https://github.com/gee-community/eetasks/issues/5)
- Internal improvements to `Export.image.to*`
- Completed the skeleton for `ui` and `Chart` so they can be silently ignored in `EE Tasks: run GEE scripts`.
2 changes: 1 addition & 1 deletion package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -77,7 +77,7 @@
"pretest": "npm run compile && npm run lint",
"lint": "eslint src --ext ts",
"test": "node ./out/test/runTest.js",
"package": "NODE_ENV=production node ./esbuild.js"
"package": "set NODE_ENV=production node ./esbuild.js"
},
"devDependencies": {
"@types/mocha": "^10.0.1",
Expand Down
6 changes: 3 additions & 3 deletions src/utilities/accountPicker.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -112,7 +112,7 @@ is picked.
Finally, calls the callback function using the picked account, project
and extra arguments
*/
export async function pickAccount(project: string | null, context: vscode.ExtensionContext, callback:any, ...args: any[] | undefined[]){
export async function pickAccount(project: string | null, context: vscode.ExtensionContext, callback:Function, ...args: any[] | undefined[]){
let accounts:any = context.globalState.get("userAccounts");
if(!accounts){
vscode.window.showInformationMessage("Looking for available accounts.");
Expand All @@ -123,7 +123,7 @@ export async function pickAccount(project: string | null, context: vscode.Extens
let nAccounts = Object.entries(accounts).length;
if(nAccounts===1){
// Only one account, so there is no need to pick
promptProject(Object.keys(accounts)[0], callback, project, ...args);
promptProject(Object.keys(accounts)[0], project, callback, ...args);
return;
}

Expand All @@ -139,7 +139,7 @@ export async function pickAccount(project: string | null, context: vscode.Extens
return;
}

export function promptProject(account:string, project:string | null, callback: any, ...args:any[] | undefined[]){
export function promptProject(account:string, project:string | null, callback: Function, ...args:any[] | undefined[]){
// If "earthengine", project is not required, so it is set to null
if(account==="earthengine"){
// No need to pick a project if using stored credentials
Expand Down
Loading