feat: report preview is now rendered using the correct template #46
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions bot
pushed a commit
that referenced
this pull request
Nov 11, 2021
# [4.0.0](v3.0.1...v4.0.0) (2021-11-11) ### Bug Fixes * an email is now sent properly with its specified type ([7dbd8a6](7dbd8a6)) * repair broken bade links ([7ec4f3a](7ec4f3a)) * set correct default email type to text ([f5299e4](f5299e4)) * update composer to reflect the latest additions ([c77ac9f](c77ac9f)) * Send as mail #19 (#43) ([12376c5](12376c5)), closes [#19](#19) [#43](#43) [#19](#19) ### Features * add semantic release to automate the release process ([0d6add6](0d6add6)) * improve default email templates ([8e14bbe](8e14bbe)) * report preview is now rendered using the correct template ([#46](#46)) ([30de8b3](30de8b3)), closes [#45](#45) ### BREAKING CHANGES * `options` are now registered with the new option syntax
|
🎉 This PR is included in version 4.0.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This MR fixes the issue that always the report template is used even if a user had configured email as report type.
Type:
textIf report email type is set to text, the email-text-template is rendered.
Type:
htmlIf report email type is set to html, the email-html-template is rendered - but the HTML isn't parsed which allows the User to preview the markup. That might change in the future.
Closes #45