-
Notifications
You must be signed in to change notification settings - Fork 138
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add github ci for alpine and static #295
Conversation
I just seen the 2 issues #293 and #291 and now I feel like a bit like if I "cross-posted" 🤣 FYI, my CI tests are here : https://github.com/thibaultduponchelle/gm/actions Static and alpine are green today and one week ago. Concerning macos, last error that I have is :
Compilation was OK when we were using the release tarball instead sources. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you!
Just a thought:
Travis CI runs make test
.
Maybe Github CI should run test also.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I personally would prefer to keep everything in Travis CI. Spreading things around to other CIs just seems like more things to check to me.
But I could probably be persuaded if everyone else thinks it's a good idea....
Also, these builds should be configured with |
That macOS bootstrapping issue is annoying. It's apparently a bug in the boostlib headers. I found some discussion and a possible workaround here: |
Github Actions (GA) CI gives us a comfortable possibility to run tests in docker containers. If I would setup CI tests this days, I would prefer GA. |
But you can do Docker containers in Travis CI, so what’s there to gain by doing a hodgepodge of both? |
Could anyone try to run MacOS build with current ax_compiler_version.m4, please? |
I haven't any experiences with Docker setup in Travis CI and obviously I got a wrong deduction from your comment here. |
Hello, You are right and I agree with you. There is no good reason to use GA instead Travis. I’m actually pushing for the idea of adding alpine/static/macOS ci but I’m not pushing for an implementation. I will maybe try to implement in Travis but can’t promise it 😄 |
I looked at travis and seems like it does not support natively docker (still feasible with Then... I skip my turn for this task and I will decline this PR 😄 to leave it to someone bolder than me 😀 |
Sorry, why does that matter? Here’s an example that uses the alpine Docker image in Travis CI: |
@thibaultduponchelle, it looks like the repository has been removed from github. I'm looking for your github action setup for MacOS. Could you share this part of code, please? |
Ah sorry I have it locally I think, will upload it that in a couple of hours |
Sorry, even locally I only have alpine.yml and static.yml :/ |
I would appreciate, if you could share both of them. I guess MacOS customization is feasible. |
Thank you, @thibaultduponchelle. I've cloned your master branch. |
By solving the bootstrapping issue, we'll run in an other once or more.
An update |
May I suggest moving discussion of macOS bootstrapping problems to issue #291? |
Hello,
Some new CI jobs so it could alert quickly if a commit breaks a different libc or a different linking method.
Could be nice to have a macos job also, but I got various non trivial errors when I tried... that's why it's not part of this PR 😁
Feel free to reimplement in travis if you prefer, but to my eyes it looked like more like a big compiler variants and versions check and I felt not comfortable to add it to travis.
Regards.
Thibault