New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Breaking change in Laravel v10.3 #42

Closed

lgebing opened this issue Mar 8, 2023 · 1 comment

lgebing commented Mar 8, 2023 •

edited

Loading

Hi, I just encountered the following error after upgrading to the newest Laravel version (10.3):

Declaration of GearboxSolutions\EloquentFileMaker\Database\Query\FMBaseBuilder::paginate($perPage = 15, $columns = [...], $pageName = 'page', $page = null) must be compatible with Illuminate\Database\Query\Builder::paginate($perPage = 15, $columns = [...], $pageName = 'page', $page = null, $total = null)

Problem is this PR which added a new parameter total to the paginate function.

The text was updated successfully, but these errors were encountered:

Author

lgebing commented Mar 9, 2023

As it looks like this is getting reverted I'm going to close this issue. Maybe something to keep in mind for the future.

lgebing closed this as completed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment