-
Notifications
You must be signed in to change notification settings - Fork 5
feat: support type aliases and includes in IDL #1175
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master-idl-v2
Are you sure you want to change the base?
Conversation
Summary of ChangesHello @m62624, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request significantly enhances the IDL system by introducing support for type aliases and a robust file inclusion mechanism. These features improve the modularity and reusability of IDL definitions, enabling developers to define custom type shortcuts and organize their IDL files more effectively. The changes are integrated across the IDL parser, metadata generation, and client generation components, ensuring comprehensive support and correct behavior for these new capabilities. Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request introduces support for type aliases and !@include directives in the IDL, which is a great feature enhancement. The changes are comprehensive, touching the parser, AST, client generator, and templates to accommodate these new features. A new preprocessor is also added to handle the include logic. The implementation is solid, but I've identified a bug in the client code generator that results in a trailing comma in generic type parameter lists. I've also noted a potential robustness issue in the preprocessor's logic for detecting top-level scope, which could be improved for future maintainability. Overall, great work on this feature.
No description provided.