- 
                Notifications
    You must be signed in to change notification settings 
- Fork 1
Closed
Labels
bugSomething isn't workingSomething isn't working
Description
The recent centralization of retries into the gdt-dev/gdt Scenario.Run method was great for taking away from plugins the need to handle retries, however some actions like create/update/delete/apply for Kubernetes should not be retried if an error is returned, otherwise you get predicatable problems:
=== RUN   TestKubernetesClusterHappyPath
[gdt] [fixtures.undercloud.start] undercloud cluster is up
=== RUN   TestKubernetesClusterHappyPath/happy-path
[gdt] [happy-path] using retry (exponential: true) [plugin default]
[gdt] [happy-path] using timeout of 5s [plugin default]
[gdt] [happy-path/0:create-cluster] kube.create: kubernetesclusters (ns: nc-system)
[gdt] [happy-path/0:create-cluster] run: attempt 1 after 600ns ok: false
[gdt] [happy-path/0:create-cluster] run: attempt 1 after 600ns failure: assertion failed: unexpected error: KubernetesCluster.aks.afo-nc.microsoft.com "" is invalid: metadata.name: Required value: name or generateName is required
[gdt] [happy-path/0:create-cluster] kube.create: kubernetesclusters (ns: nc-system)
[gdt] [happy-path/0:create-cluster] run: attempt 2 after 379.63448ms ok: false
[gdt] [happy-path/0:create-cluster] run: attempt 2 after 379.63448ms failure: assertion failed: unexpected error: KubernetesCluster.aks.afo-nc.microsoft.com "" is invalid: metadata.name: Required value: name or generateName is required
[gdt] [happy-path/0:create-cluster] kube.create: kubernetesclusters (ns: nc-system)
[gdt] [happy-path/0:create-cluster] run: attempt 3 after 1.500700752s ok: false
[gdt] [happy-path/0:create-cluster] run: attempt 3 after 1.500700752s failure: assertion failed: unexpected error: KubernetesCluster.aks.afo-nc.microsoft.com "" is invalid: metadata.name: Required value: name or generateName is required
[gdt] [happy-path/0:create-cluster] kube.create: kubernetesclusters (ns: nc-system)
[gdt] [happy-path/0:create-cluster] run: attempt 4 after 2.265334563s ok: false
[gdt] [happy-path/0:create-cluster] run: attempt 4 after 2.265334563s failure: assertion failed: unexpected error: KubernetesCluster.aks.afo-nc.microsoft.com "" is invalid: metadata.name: Required value: name or generateName is required
[gdt] [happy-path/0:create-cluster] kube.create: kubernetesclusters (ns: nc-system)
[gdt] [happy-path/0:create-cluster] run: attempt 5 after 4.005659175s ok: false
[gdt] [happy-path/0:create-cluster] run: attempt 5 after 4.005659175s failure: assertion failed: unexpected error: KubernetesCluster.aks.afo-nc.microsoft.com "" is invalid: metadata.name: Required value: name or generateName is required
    run.go:116: assertion failed: unexpected error: KubernetesCluster.aks.afo-nc.microsoft.com "" is invalid: metadata.name: Required value: name or generateName is required
[gdt] [happy-path] wait: 5m before
^Csignal: interrupt
Metadata
Metadata
Assignees
Labels
bugSomething isn't workingSomething isn't working