simplify Evaluable interface and Scenario.Run #33
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
No longer pass the `*testing.T` down into Plugin's Spec.Eval() method, freeing up plugins to focus on actions and assertions. Scenario.Run() now handles the `*testing.T` and the trace context centrally instead of plugins needing to do this. Also simplifies the Scenario.Run() interface and Evaluable.Eval() interfaces to return (result.Result, error) to more cleanly pass back RuntimeErrors instead of needing a Result.RuntimeError() method. Signed-off-by: Jay Pipes <jaypipes@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No longer pass the
*testing.Tdown into Plugin's Spec.Eval() method, freeing up plugins to focus on actions and assertions. Scenario.Run() now handles the*testing.Tand the trace context centrally instead of plugins needing to do this.Also simplifies the Scenario.Run() interface and Evaluable.Eval() interfaces to return (result.Result, error) to more cleanly pass back RuntimeErrors instead of needing a Result.RuntimeError() method.