add custom retry configuration #30
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adds the ability to configure retry behaviour for any test spec, using either a constant interval or an exponential backoff. In doing so, reworks the framework to have all calls to testing.T.Errorf() happen in the Scenario.Run() method, as well as have that method handle all retries. gdt-kube will need to be refactored to remove the retry behaviour implemented in that plugin. Also, this finally fixes the way that failures are tested by using the strategy outlined in golang/go#39903. Issue #26 Signed-off-by: Jay Pipes <jaypipes@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds the ability to configure retry behaviour for any test spec, using either a constant interval or an exponential backoff.
In doing so, reworks the framework to have all calls to testing.T.Errorf() happen in the Scenario.Run() method, as well as have that method handle all retries. gdt-kube will need to be refactored to remove the retry behaviour implemented in that plugin.
Also, this finally fixes the way that failures are tested by using the strategy outlined in golang/go#39903.
Issue #26