Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

documentation #46

Open
tpapp opened this issue Jun 21, 2022 · 1 comment
Open

documentation #46

tpapp opened this issue Jun 21, 2022 · 1 comment

Comments

@tpapp
Copy link
Contributor

tpapp commented Jun 21, 2022

I find this package extremely useful, and I think that it is sufficiently mature that it would benefit from documentation. I am opening this issue to discuss how to do this, and would be happy to contribute PRs.

What I am missing the most is details on computations, especially invariants that need to be satisfied, at least approximately. Eg

using WeightedOnlineStats
stat = WeightedMean()
fit!(stat, x, weights)
m = mean(stat)

then the expected invariant is

$$ m = \frac{\sum_i x_i w_i}{\sum_i w_i} $$

The example is deliberately trivial; for other moments I am not a 100% sure what the result is without looking at the code in detail. Formulas in docstrings would help. A lot of this is already used in tests.

It would also be great to have references to algorithms where applicable.

Setting up automatic docs generation using Documenter.jl would be a nice start, even if it is WIP. Ideally I would prefer to make small PRs.

@gdkrmr
Copy link
Owner

gdkrmr commented Jul 1, 2022

I have made some basic Documenter.jl work and there is a rudimentary documentation available now under https://www.guido-kraemer.com/WeightedOnlineStats.jl/

I'll leave this issue open to track the details for adding more documentation

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants