Skip to content

Icon color components as doubles through pigeon #353

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 29, 2025
Merged

Icon color components as doubles through pigeon #353

merged 1 commit into from
Mar 29, 2025

Conversation

nicolausgr
Copy link
Contributor

As @orkun1675 pointed out, it's a better decision to pass the color components as doubles through pigeon.

In Kotlin, we still need to convert them from Double to Float for passing them to Color.argb() method.

@nicolausgr nicolausgr mentioned this pull request Mar 28, 2025
Merged
orkun1675
orkun1675 approved these changes Mar 29, 2025
View reviewed changes
Copy link
Collaborator

@orkun1675 orkun1675 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the improvement!

@orkun1675 orkun1675 merged commit 14cff0d into gdelataillade:main Mar 29, 2025
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@orkun1675 orkun1675 orkun1675 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@nicolausgr @orkun1675