Open
Conversation
1 task
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #300 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 20 20
Lines 2139 2143 +4
=========================================
+ Hits 2139 2143 +4 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
gdalle
reviewed
Jan 19, 2026
Owner
gdalle
left a comment
There was a problem hiding this comment.
Is acyclic coloring the only kind where empty matrices are problematic? What happens if only one dimension of the matrix is zero?
The fix is welcome (even though its usefulness isn't obvious to me), but then we may want to fix everything at once
Co-authored-by: Guillaume Dalle <22795598+gdalle@users.noreply.github.com>
e8e4ee6 to
266784e
Compare
gdalle
requested changes
Jan 29, 2026
gdalle
reviewed
Jan 29, 2026
gdalle
approved these changes
Jan 29, 2026
Owner
gdalle
left a comment
There was a problem hiding this comment.
Thanks! Let's merge if the tests pass
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The change to
_coloringfixes the following error:After this, we have the following error that is fixed by the change in
group_by_color:Will add tests if this changes looks reasonable.