Add tests on structured matrices #136
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gdalle
commented
Oct 3, 2024
| @test structurally_orthogonal_columns(A, color) | ||
| if VERSION >= v"1.10" || A isa Union{Diagonal,Bidiagonal,Tridiagonal} | ||
| # banded matrices not supported by ArrayInterface on Julia 1.6 | ||
| # @test color == ArrayInterface.matrix_colors(A) # TODO: uncomment |
There was a problem hiding this comment.
To merge #132, this needs to be uncommented
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #136 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 11 11
Lines 871 871
=========================================
Hits 871 871 ☔ View full report in Codecov by Sentry. |
|
Superseded by #137 (I screwed up with a |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a version of #132 without the optimized implementations, just adding some tests for the following structured matrix types.
DiagonalBidiagonalTridiagonalBandedMatrixBlockBandedMatrixBandedBlockBandedMatrixThe fallback decompression already works without error: it follows the sparsity pattern, so it avoids writing into forbidden locations (say, outside of the diagonal for a
Diagonal).