Skip to content

Commit

Permalink
wintest: Fix invalid escape sequences
Browse files Browse the repository at this point in the history
Signed-off-by: Joseph Sutton <josephsutton@catalyst.net.nz>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>

Autobuild-User(master): Andrew Bartlett <abartlet@samba.org>
Autobuild-Date(master): Fri Oct 13 04:55:06 UTC 2023 on atb-devel-224
  • Loading branch information
jsutton24 authored and abartlet committed Oct 13, 2023
1 parent 3f70da6 commit d895c98
Show file tree
Hide file tree
Showing 2 changed files with 16 additions and 16 deletions.
14 changes: 7 additions & 7 deletions wintest/test-s4-howto.py
Original file line number Diff line number Diff line change
Expand Up @@ -160,7 +160,7 @@ def run_dcpromo(t, vm):
t.info("Joining a windows VM ${WIN_VM} to the domain as a DC using dcpromo")
child = t.open_telnet("${WIN_HOSTNAME}", "administrator", "${WIN_PASS}", set_ip=True, set_noexpire=True)
child.sendline("copy /Y con answers.txt")
child.sendline(b'''
child.sendline(br'''
[DCINSTALL]
RebootOnSuccess=Yes
RebootOnCompletion=Yes
Expand All @@ -171,7 +171,7 @@ def run_dcpromo(t, vm):
ConfirmGc=Yes
CreateDNSDelegation=No
UserDomain=${LCREALM}
UserName=${LCREALM}\\administrator
UserName=${LCREALM}\administrator
Password=${PASSWORD1}
DatabasePath="C:\Windows\NTDS"
LogPath="C:\Windows\NTDS"
Expand All @@ -187,7 +187,7 @@ def run_dcpromo(t, vm):
if i == 1 or i == 2:
child.sendline("echo off")
child.sendline("echo START DCPROMO log")
child.sendline("more c:\windows\debug\dcpromoui.log")
child.sendline(r"more c:\windows\debug\dcpromoui.log")
child.sendline("echo END DCPROMO log")
child.expect("END DCPROMO")
raise Exception("dcpromo failed")
Expand Down Expand Up @@ -315,7 +315,7 @@ def run_dcpromo_rodc(t, vm):
t.vm_restore("${WIN_VM}", "${WIN_SNAPSHOT}")
child = t.open_telnet("${WIN_HOSTNAME}", "administrator", "${WIN_PASS}", set_ip=True)
child.sendline("copy /Y con answers.txt")
child.sendline(b'''
child.sendline(br'''
[DCInstall]
ReplicaOrNewDomain=ReadOnlyReplica
ReplicaDomainDNSName=${LCREALM}
Expand All @@ -325,13 +325,13 @@ def run_dcpromo_rodc(t, vm):
PasswordReplicationDenied="BUILTIN\Account Operators"
PasswordReplicationDenied="${DOMAIN}\Denied RODC Password Replication Group"
PasswordReplicationAllowed="${DOMAIN}\Allowed RODC Password Replication Group"
DelegatedAdmin="${DOMAIN}\\Administrator"
DelegatedAdmin="${DOMAIN}\Administrator"
SiteName=Default-First-Site-Name
InstallDNS=No
ConfirmGc=Yes
CreateDNSDelegation=No
UserDomain=${LCREALM}
UserName=${LCREALM}\\administrator
UserName=${LCREALM}\administrator
Password=${PASSWORD1}
DatabasePath="C:\Windows\NTDS"
LogPath="C:\Windows\NTDS"
Expand All @@ -346,7 +346,7 @@ def run_dcpromo_rodc(t, vm):
if i != 0:
child.sendline("echo off")
child.sendline("echo START DCPROMO log")
child.sendline("more c:\windows\debug\dcpromoui.log")
child.sendline(r"more c:\windows\debug\dcpromoui.log")
child.sendline("echo END DCPROMO log")
child.expect("END DCPROMO")
raise Exception("dcpromo failed")
Expand Down
18 changes: 9 additions & 9 deletions wintest/wintest.py
Original file line number Diff line number Diff line change
Expand Up @@ -295,7 +295,7 @@ def get_nameserver(self):
if i == 0:
child.expect('your original resolv.conf')
child.expect('nameserver')
child.expect('\d+.\d+.\d+.\d+')
child.expect(r'\d+.\d+.\d+.\d+')
return child.after

def rndc_cmd(self, cmd, checkfail=True):
Expand Down Expand Up @@ -554,16 +554,16 @@ def get_ipconfig(self, child):
'''get the IP configuration of the child'''
child.sendline("ipconfig /all")
child.expect('Ethernet adapter ')
child.expect("[\w\s]+")
child.expect(r"[\w\s]+")
self.setvar("WIN_NIC", child.after)
child.expect(['IPv4 Address', 'IP Address'])
child.expect('\d+.\d+.\d+.\d+')
child.expect(r'\d+.\d+.\d+.\d+')
self.setvar('WIN_IPV4_ADDRESS', child.after)
child.expect('Subnet Mask')
child.expect('\d+.\d+.\d+.\d+')
child.expect(r'\d+.\d+.\d+.\d+')
self.setvar('WIN_SUBNET_MASK', child.after)
child.expect('Default Gateway')
i = child.expect(['\d+.\d+.\d+.\d+', "C:"])
i = child.expect([r'\d+.\d+.\d+.\d+', "C:"])
if i == 0:
self.setvar('WIN_DEFAULT_GATEWAY', child.after)
child.expect("C:")
Expand All @@ -581,7 +581,7 @@ def get_is_dc(self, child):
child.expect("C:")
child.sendline("net config Workstation")
child.expect("Workstation domain")
child.expect('[\S]+')
child.expect(r'[\S]+')
domain = child.after
i = child.expect(["Workstation Domain DNS Name", "Logon domain"])
'''If we get the Logon domain first, we are not in an AD domain'''
Expand All @@ -590,7 +590,7 @@ def get_is_dc(self, child):
if domain.upper() == self.getvar("WIN_DOMAIN").upper():
return True

child.expect('[\S]+')
child.expect(r'[\S]+')
hostname = child.after
if hostname.upper() == self.getvar("WIN_HOSTNAME").upper():
return True
Expand Down Expand Up @@ -659,7 +659,7 @@ def resolve_ip(self, hostname, retries=60, delay=5):
child = self.pexpect_spawn("bin/nmblookup %s" % hostname)
i = 0
while i == 0:
i = child.expect(["querying", '\d+.\d+.\d+.\d+', hostname, "Lookup failed"])
i = child.expect(["querying", r'\d+.\d+.\d+.\d+', hostname, "Lookup failed"])
if i == 0:
child.expect("\r")
if i == 1:
Expand Down Expand Up @@ -833,7 +833,7 @@ def run_dcpromo_as_first_dc(self, vm, func_level=None):

"""This server must therefore not yet be a directory server, so we must promote it"""
child.sendline("copy /Y con answers.txt")
child.sendline(b'''
child.sendline(br'''
[DCInstall]
; New forest promotion
ReplicaOrNewDomain=Domain
Expand Down

0 comments on commit d895c98

Please sign in to comment.