Skip to content

Commit

Permalink
CVE-2018-14628: s4:setup: set the correct nTSecurityDescriptor on the…
Browse files Browse the repository at this point in the history
… CN=Deleted Objects container

This revealed a bug in our dirsync code, so we mark
test_search_with_dirsync_deleted_objects as knownfail.

BUG: https://bugzilla.samba.org/show_bug.cgi?id=13595

Signed-off-by: Stefan Metzmacher <metze@samba.org>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
  • Loading branch information
metze-samba committed Oct 16, 2023
1 parent 0c329a0 commit 7f8b15f
Show file tree
Hide file tree
Showing 4 changed files with 4 additions and 0 deletions.
1 change: 1 addition & 0 deletions selftest/knownfail.d/samba4.ldap.confidential_attr
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
^samba4.ldap.confidential_attr.python.*.__main__.*.test_search_with_dirsync_deleted_objects
1 change: 1 addition & 0 deletions source4/setup/provision.ldif
Original file line number Diff line number Diff line change
Expand Up @@ -34,6 +34,7 @@ isDeleted: TRUE
isCriticalSystemObject: TRUE
showInAdvancedViewOnly: TRUE
systemFlags: -1946157056
nTSecurityDescriptor:: ${DELETEDOBJECTS_DESCRIPTOR}

# Computers located in "provision_computers*.ldif"
# Users/Groups located in "provision_users*.ldif"
Expand Down
1 change: 1 addition & 0 deletions source4/setup/provision_configuration.ldif
Original file line number Diff line number Diff line change
Expand Up @@ -14,6 +14,7 @@ description: Container for deleted objects
isDeleted: TRUE
isCriticalSystemObject: TRUE
systemFlags: -1946157056
nTSecurityDescriptor:: ${DELETEDOBJECTS_DESCRIPTOR}

# Extended rights

Expand Down
1 change: 1 addition & 0 deletions source4/setup/provision_dnszones_add.ldif
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,7 @@ description: Deleted objects
isDeleted: TRUE
isCriticalSystemObject: TRUE
systemFlags: -1946157056
nTSecurityDescriptor:: ${DELETEDOBJECTS_DESCRIPTOR}

dn: CN=LostAndFound,${ZONE_DN}
objectClass: top
Expand Down

0 comments on commit 7f8b15f

Please sign in to comment.