-
Notifications
You must be signed in to change notification settings - Fork 19
Issue 6471 - When two bulk import jobs extend the partition tree at once, one fails #6496
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
patchwork01
wants to merge
21
commits into
develop
Choose a base branch
from
6471-extend-partition-tree-conflict
base: develop
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+464
−27
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
patchwork01
commented
Jan 30, 2026
...ort/bulk-import-runner/src/test/java/sleeper/bulkimport/runner/PartitionPreSplitterTest.java
Outdated
Show resolved
Hide resolved
...ort/bulk-import-runner/src/test/java/sleeper/bulkimport/runner/PartitionPreSplitterTest.java
Outdated
Show resolved
Hide resolved
...ort/bulk-import-runner/src/test/java/sleeper/bulkimport/runner/PartitionPreSplitterTest.java
Outdated
Show resolved
Hide resolved
| .isInstanceOf(TooManyAttemptsPartitionSplitterException.class); | ||
|
|
||
| } | ||
|
|
Collaborator
Author
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It doesn't look like we're testing that the pre-splitter can actually perform a retry. Here are some potential tests:
- We want to split from 1 to 4 partitions. On the first attempt, it conflicts as another process splits to 2 partitions. On the second attempt, it regenerates the sketches for the new leaf partitions and successfully splits to 4 partitions.
- We want to split from 1 to 8 partitions. We allow 2 attempts. On the first attempt, it conflicts as another process splits to 2 partitions. On the second attempt, it conflicts as another process splits to 4 partitions. It fails because it runs out of attempts.
patchwork01
commented
Feb 2, 2026
...ort/bulk-import-runner/src/test/java/sleeper/bulkimport/runner/PartitionPreSplitterTest.java
Show resolved
Hide resolved
...ort/bulk-import-runner/src/test/java/sleeper/bulkimport/runner/PartitionPreSplitterTest.java
Show resolved
Hide resolved
...ort/bulk-import-runner/src/test/java/sleeper/bulkimport/runner/PartitionPreSplitterTest.java
Outdated
Show resolved
Hide resolved
...ort/bulk-import-runner/src/test/java/sleeper/bulkimport/runner/PartitionPreSplitterTest.java
Outdated
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Make sure you have checked all steps below.
Issue
Feature". Note that before an issue is finished, you can still make a pull request by raising a separate issue
for your progress.
Tests
Documentation
separate issue for that below.