Skip to content

Conversation

@patchwork01
Copy link
Collaborator

Make sure you have checked all steps below.

Issue

Tests

  • My PR adds the following tests based on our test strategy OR does not need testing for this extremely good reason:
    • PartitionPreSplitterTest
    • Updated BulkImportJobDriverTest

Documentation

  • In case of new functionality, my PR adds documentation that describes how to use it, or I have linked to a
    separate issue for that below.
  • If I have added new Java code, I have added Javadoc that explains it following our conventions and style.
  • If I have added or removed any dependencies from the project, I have updated the NOTICES file.

@Rob9786 Rob9786 added the needs-reviewer Pull requests that need a reviewer to be assigned label Jan 30, 2026
@Rob9786 Rob9786 marked this pull request as ready for review January 30, 2026 12:28
.isInstanceOf(TooManyAttemptsPartitionSplitterException.class);

}

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It doesn't look like we're testing that the pre-splitter can actually perform a retry. Here are some potential tests:

  • We want to split from 1 to 4 partitions. On the first attempt, it conflicts as another process splits to 2 partitions. On the second attempt, it regenerates the sketches for the new leaf partitions and successfully splits to 4 partitions.
  • We want to split from 1 to 8 partitions. We allow 2 attempts. On the first attempt, it conflicts as another process splits to 2 partitions. On the second attempt, it conflicts as another process splits to 4 partitions. It fails because it runs out of attempts.

@patchwork01 patchwork01 removed the needs-reviewer Pull requests that need a reviewer to be assigned label Jan 30, 2026
@Rob9786 Rob9786 changed the title Issue 6471 - Resolve conflicts extending partition tree Issue 6471 - When two bulk import jobs extend the partition tree at once, one fails Feb 3, 2026
@patchwork01 patchwork01 assigned patchwork01 and unassigned Rob9786 Feb 4, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

When two bulk import jobs extend the partition tree at once, one fails

3 participants