Fix: Add input validation for XOR Checksum blocksize (#2537)#2542
Open
dweep-js wants to merge 2 commits into
Open
Fix: Add input validation for XOR Checksum blocksize (#2537)#2542dweep-js wants to merge 2 commits into
dweep-js wants to merge 2 commits into
Conversation
Added validation for blocksize and imported OperationError for error handling. fixes Issue gchq#2537.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This pull request adds input validation to the XOR Checksum operation (
src/core/operations/XORChecksum.mjs). Previously, entering a decimal (float) or a negative value as theBlocksizeparameter would pass straight to the JavaScript array constructor (Array(blocksize)), triggering an uncaughtRangeError: invalid array lengthand crashing the application's runtime.This fix introduces an explicit check using
Number.isInteger()and bounds validation (<= 0) right at the start of therunmethod. If the user passes an invalid block size, it now gracefully interrupts execution and throws a user-friendlyOperationError, displaying a clear error message in the output panel instead of crashing.Existing Issue
Fixes #2537
Screenshots
1.1or-1causes a frozen screen or a blank output box, with a redRangeErrorappearing in the browser's developer console.1.1or-1immediately shows a clean, red error banner in the output pane stating:Blocksize must be a positive integer.Test Coverage
Tested manually via the local web server (
localhost:8080) using the exact inputs from the bug report:1.1-> Successfully caught by validation, showsBlocksize must be a positive integer.-1-> Successfully caught by validation, showsBlocksize must be a positive integer.4(Valid integer) -> Runs successfully without errors, matching original expected behavior.