fix: handle AMF3 JSON values and invalid decode input#2528
Open
skyswordw wants to merge 3 commits into
Open
Conversation
1bb6546 to
378eb0c
Compare
Author
|
Thanks, I went with option 2 here. The AMF decode tests have been folded into Validated locally with Node v24.16.0:
|
Contributor
|
Just checking - this PR is showing as "Draft"/"Not Ready" which indicates that it is not yet ready for merge. If you are still working on it that's absolutely fine, but if it's actually ready for formal review then could you change the state to "Ready for Review". |
Author
|
Thanks for checking. The follow-up change is in and the review thread is resolved, so I will move this to Ready for Review now. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
@astronautlabs/amfValue.any()pathOperationErrormessages instead of surfacing low-level parser errorsAMF.mjsoperation test fileFixes #2490.
Fixes #2491.
Fixes #2492.
Validation
npx grunt configTests11passing)npm run lintNODE_OPTIONS=--openssl-legacy-provider npm test(245Node API tests and1971operation tests passing)git diff --checkNotes:
npm cicompleted under Node v24.16.0 earlier in this branch. It reported the repository's existing deprecation/audit warnings, including36 vulnerabilities; no dependency changes were made.Development disclosure
I developed this change collaboratively with OpenAI Codex, with local review and validation before submission.