Fix Swap endianness data format validation#2515
Open
marko1olo wants to merge 1 commit into
Open
Conversation
|
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fix
Swap endiannessso an invalid or empty data format argument produces a controlled operation error instead of falling through with the raw input string and later throwingword.push is not a function.This covers the issue reproduction from #2495, where a deep link can pass an empty first argument:
Swap_endianness('',2,true).Test plan
npx grunt configTestsnode --no-warnings --no-deprecation --openssl-legacy-provider tests/operations/index.mjs->TOTAL 1962,PASSING 1962npx eslint src/core/operations/SwapEndianness.mjs tests/operations/index.mjs tests/operations/tests/SwapEndianness.mjsgit diff --cached --checkbefore commitNote: the first
npm ciattempt hit a networkECONNRESET, and a retry timed out locally. The dependencies installed far enough for the targeted lint, config generation, and full operation test suite above to pass.Fixes #2495.