fix: validate hexdump width upper bound#2514
Open
skyswordw wants to merge 1 commit into
Open
Conversation
Author
|
CLA is signed now, so I am marking this ready for review. Local checks completed before opening the PR:
|
bc65a40 to
b50bb88
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
To Hexdumpwidth argument at a documented maximumOperationErrorfor oversized widths instead of surfacing a runtimeRangeErrorWhy
A very large width value can reach
String.padEnd()and throw an uncaughtRangeErrorbefore CyberChef can present a normal operation error. Validating the width keeps the operation failure user-facing and bounded.Fixes #2483.
Checks
npm cinpm run lintnpm test13passing)git diff --check