Skip to content

fix: GetAllCasings.mjs - newline bug #1328

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Mar 29, 2022
Merged

fix: GetAllCasings.mjs - newline bug #1328

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
e2b7ac6
fix: GetAllCasings.mjs - newline bug
pH-T Mar 28, 2022
9ad4e25
fix: GetAllCasings.mjs test
pH-T Mar 28, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/core/operations/GetAllCasings.mjs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -46,7 +46,7 @@ class GetAllCasings extends Operation {
}
result += temp.join("") + "\n";
}
return result;
return result.slice(0, -1);
}
}

Expand Down
6 changes: 3 additions & 3 deletions tests/operations/tests/GetAllCasings.mjs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@ TestRegister.addTests([
{
name: "All casings of test",
input: "test",
expectedOutput: "test\nTest\ntEst\nTEst\nteSt\nTeSt\ntESt\nTESt\ntesT\nTesT\ntEsT\nTEsT\nteST\nTeST\ntEST\nTEST\n",
expectedOutput: "test\nTest\ntEst\nTEst\nteSt\nTeSt\ntESt\nTESt\ntesT\nTesT\ntEsT\nTEsT\nteST\nTeST\ntEST\nTEST",
recipeConfig: [
{
"op": "Get All Casings",
Expand All @@ -22,7 +22,7 @@ TestRegister.addTests([
{
name: "All casings of t",
input: "t",
expectedOutput: "t\nT\n",
expectedOutput: "t\nT",
recipeConfig: [
{
"op": "Get All Casings",
Expand All @@ -33,7 +33,7 @@ TestRegister.addTests([
{
name: "All casings of null",
input: "",
expectedOutput: "\n",
expectedOutput: "",
recipeConfig: [
{
"op": "Get All Casings",
Expand Down