Added API end points for creating and viewing review roles #2159
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ARADDCC002
added
enhancement
PE39806
previously approved these changes
Apr 25, 2025
JR40159
requested changes
Apr 28, 2025
| } | ||
|
|
||
| onUpdateReviewRole(req: Request, reviewRole: ReviewRoleInterface) { | ||
| this.checkEventType(AuditInfo.CreateReviewRole, req) |
| } | ||
|
|
||
| onViewReviewRoles(req: Request) { | ||
| this.checkEventType(AuditInfo.ViewReviewRole, req) |
backend/src/models/ReviewRole.ts
Outdated
| }, | ||
| { | ||
| timestamps: true, | ||
| collection: 'v2_webhooks', |
backend/src/connectors/audit/Base.ts
Outdated
| description: 'Created a new review role', | ||
| auditKind: AuditKind.Create, | ||
| }, | ||
| ViewReviewRole: { |
There was a problem hiding this comment.
Should this be ViewReviewRoles?
There was a problem hiding this comment.
I've added both in case we want a dedicated end point for viewing single review roles by id in the future
backend/src/connectors/audit/Base.ts
Outdated
| @@ -192,6 +203,11 @@ export abstract class BaseAuditConnector { | |||
| importResult: MongoDocumentImportInformation | FileImportInformation, | |||
| ) | |||
|
|
|||
| abstract onCreateReviewRole(req: Request, reviewRole: ReviewRoleInterface) | |||
| abstract onUpdateReviewRole(req: Request, reviewRole: ReviewRoleInterface) | |||
There was a problem hiding this comment.
It might be pre-emptive, but I thought I'd cover possible future end points that might allow for modifying review roles.
backend/src/connectors/audit/Base.ts
Outdated
| @@ -192,6 +203,11 @@ export abstract class BaseAuditConnector { | |||
| importResult: MongoDocumentImportInformation | FileImportInformation, | |||
| ) | |||
|
|
|||
| abstract onCreateReviewRole(req: Request, reviewRole: ReviewRoleInterface) | |||
| abstract onUpdateReviewRole(req: Request, reviewRole: ReviewRoleInterface) | |||
| abstract onViewReviewRole(req: Request, reviewRoles: ReviewRoleInterface) | |||
There was a problem hiding this comment.
For simplicity I'd rather we just add audit stuff for the stuff we have rather than including code for stuff we might have in the future
| } catch (error) { | ||
| handleDuplicateKeys(error) | ||
| throw error | ||
| } |
There was a problem hiding this comment.
For other create service functions, we normally return the new mongo model
JR40159
approved these changes
May 6, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Review roles are a WIP part of dynamic role work. Bailo currently relies on statically defined review roles, whereas in the future we want admins to be able to create whatever role they want for the review process.