Stable support #39
Merged
Stable support #39
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can you determine whether or not RustBox is "Send" when the negative trait is removed? You can force it to be "Not Send" by adding a PhantomData marker for a type which is "Not Send" This seems to work with stable. |
Without it, I get the following error on 1.1 stable :
src/rustbox.rs:222:1: 222:39 error: negative trait bounds are not yet fully
implemented; use marker types for now
src/rustbox.rs:222 impl !std::marker::Send for RustBox {}
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
|
What's cool with rust (and haskell (and cool languages)) is that you always have something to learn ^^ |
|
Did you have time to review the changes ? |
|
Sorry for the delay, thanks for this @Yamakaky! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With these changes, it compiles on stable 1.1. The Send is a problem though.
See #36