declare: remove unnecessary limitation, fix #291

gcanti · Sep 1, 2017 · 11388e7 · 11388e7
1 parent 5bbaf1a
commit 11388e7
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 8 deletions.
diff --git a/lib/declare.js b/lib/declare.js
@@ -31,7 +31,7 @@ module.exports = function declare(name) {
     if (process.env.NODE_ENV !== 'production') {
       assert(isType(spec), function () { return 'Invalid argument type ' + assert.stringify(spec) +  ' supplied to define(type) (expected a type)'; });
       assert(isNil(type), function () { return 'Declare.define(type) can only be invoked once'; });
-      assert(isNil(spec.meta.name) && Object.keys(spec.prototype).length === 0, function () { return 'Invalid argument type ' + assert.stringify(spec) + ' supplied to define(type) (expected a fresh, unnamed type)'; });
+      // assert(isNil(spec.meta.name) && Object.keys(spec.prototype).length === 0, function () { return 'Invalid argument type ' + assert.stringify(spec) + ' supplied to define(type) (expected a fresh, unnamed type)'; });
     }
 
     if (isUnion(spec) && Declare.hasOwnProperty('dispatch')) {

diff --git a/test/declare.js b/test/declare.js
@@ -89,12 +89,12 @@ describe('t.declare([name])', function () {
       assert.equal(42, Struct({value: 42}).getValue());
     });
 
-    it('should throw when defined with a non-fresh type', function() {
-      throwsWithMessage(function () {
-        var ANum = t.declare();
-        ANum.define(t.Number);
-      }, '[tcomb] Invalid argument type "Number" supplied to define(type) (expected a fresh, unnamed type)');
-    });
+    // it('should throw when defined with a non-fresh type', function() {
+    //   throwsWithMessage(function () {
+    //     var ANum = t.declare();
+    //     ANum.define(t.Number);
+    //   }, '[tcomb] Invalid argument type "Number" supplied to define(type) (expected a fresh, unnamed type)');
+    // });
 
     it('should play well with identity', function () {
       var Tuple = t.declare('Tuple');
@@ -192,4 +192,4 @@ describe('t.declare([name])', function () {
 
   });
 
-});
+});