Skip to content

Commit

Permalink
leds: leds-cobalt-raq: use devm_ioremap
Browse files Browse the repository at this point in the history
The devm_ functions allocate memory that is released when a driver
detaches. This patch uses devm_ioremap() for these functions.

Signed-off-by: Jingoo Han <jg1.han@samsung.com>
Signed-off-by: Bryan Wu <cooloney@gmail.com>
  • Loading branch information
Jingoo Han authored and cooloney committed Nov 26, 2012
1 parent aa2dcf9 commit 50e5194
Showing 1 changed file with 4 additions and 7 deletions.
11 changes: 4 additions & 7 deletions drivers/leds/leds-cobalt-raq.c
Original file line number Diff line number Diff line change
Expand Up @@ -85,13 +85,13 @@ static int __devinit cobalt_raq_led_probe(struct platform_device *pdev)
if (!res)
return -EBUSY;

led_port = ioremap(res->start, resource_size(res));
led_port = devm_ioremap(&pdev->dev, res->start, resource_size(res));
if (!led_port)
return -ENOMEM;

retval = led_classdev_register(&pdev->dev, &raq_power_off_led);
if (retval)
goto err_iounmap;
goto err_null;

retval = led_classdev_register(&pdev->dev, &raq_web_led);
if (retval)
Expand All @@ -102,8 +102,7 @@ static int __devinit cobalt_raq_led_probe(struct platform_device *pdev)
err_unregister:
led_classdev_unregister(&raq_power_off_led);

err_iounmap:
iounmap(led_port);
err_null:
led_port = NULL;

return retval;
Expand All @@ -114,10 +113,8 @@ static int __devexit cobalt_raq_led_remove(struct platform_device *pdev)
led_classdev_unregister(&raq_power_off_led);
led_classdev_unregister(&raq_web_led);

if (led_port) {
iounmap(led_port);
if (led_port)
led_port = NULL;
}

return 0;
}
Expand Down

0 comments on commit 50e5194

Please sign in to comment.