Use the telemetry logger in the WalkingModule #97
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
paolo-viceconte
requested review from
GiulioRomualdi,
S-Dafarra and
isorrentino
isorrentino
force-pushed
the
test/telemetry_logger_rebased
branch
from
0c7365c to
5752d4a
Compare
isorrentino
requested changes
Jan 7, 2022
| timeWeight 2.5 | ||
| positionWeight 1.0 | ||
| slowWhenTurningGain 5.0 | ||
| slowWhenTurningGain 2.5 |
Collaborator
There was a problem hiding this comment.
This parameter should be increased again as the robot falls down when turning due to the high speed. We could try with 4 if we want to take a higher velocity with respect to the previous value. But the new value should be tested before merging the PR.
cc @S-Dafarra
Contributor
Author
There was a problem hiding this comment.
We won't be able to test the new gain for a while. Should we revert to 5.0 and merge the PR, leaving for later the tuning of this gain?
Collaborator
|
Nice catches @isorrentino! |
Co-authored-by: Giulio Romualdi <giulio.romualdi@gmail.com>
Co-authored-by: Giulio Romualdi <giulio.romualdi@gmail.com>
GiulioRomualdi
changed the title
This was referenced Feb 3, 2022
Merged
This was referenced Sep 22, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.